What happened? in [] value transp

Closed by <a class="issue-link js-issue-link" data-error-text="Failed to load title" d

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

using `in` with an empty array pattern produces invalid SQL about prql HOT 2 CLOSED

Globidev commented on September 27, 2024 1

using `in` with an empty array pattern produces invalid SQL

from prql.

Comments (2)

PrettyWood commented on September 27, 2024 2

Closed by #4598

from prql.

max-sixty commented on September 27, 2024

Thanks @Globidev . Indeed, seems like we should we working around that postgres issue. (Ideally postgres would allow an empty list!).

This would likely be a fairly small PR into

prql/prqlc/prqlc/src/sql/gen_expr.rs

Lines 159 to 186 in 2f2c08b

 /// Translates into IN (v1, v2, ...) if possible 

 fn process_array_in(expr: &Expr, args: &[Expr], ctx: &mut Context) -> Result<sql_ast::Expr> { 

 match args { 

 [col_expr @ Expr { 

 kind: 

 ExprKind::ColumnRef(_) 

 | ExprKind::Literal(_) 

 | ExprKind::SString(_) 

 | ExprKind::Param(_) 

 | ExprKind::Operator { name: _, args: _ }, 

 .. 

 }, Expr { 

 kind: ExprKind::Array(in_values), 

 .. 

 }] => Ok(sql_ast::Expr::InList { 

 expr: Box::new(translate_expr(col_expr.clone(), ctx)?.into_ast()), 

 list: in_values 

 .iter() 

 .map(|a| Ok(translate_expr(a.clone(), ctx)?.into_ast())) 

 .collect::<Result<Vec<sql_ast::Expr>>>()?, 

 negated: false, 

 }), 

 _ => Err( 

 Error::new_simple("args to `std.array_in` must be an expression and an array") 

 .with_span(expr.span), 

 ), 

 } 

 }

if anyone wants to give it a go.

from prql.

using `in` with an empty array pattern produces invalid SQL about prql HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/// Translates into IN (v1, v2, ...) if possible
	fn process_array_in(expr: &Expr, args: &[Expr], ctx: &mut Context) -> Result<sql_ast::Expr> {
	match args {
	[col_expr @ Expr {
	kind:
	ExprKind::ColumnRef(_)
	\| ExprKind::Literal(_)
	\| ExprKind::SString(_)
	\| ExprKind::Param(_)
	\| ExprKind::Operator { name: _, args: _ },
	..
	}, Expr {
	kind: ExprKind::Array(in_values),
	..
	}] => Ok(sql_ast::Expr::InList {
	expr: Box::new(translate_expr(col_expr.clone(), ctx)?.into_ast()),
	list: in_values
	.iter()
	.map(\|a\| Ok(translate_expr(a.clone(), ctx)?.into_ast()))
	.collect::<Result<Vec<sql_ast::Expr>>>()?,
	negated: false,
	}),
	_ => Err(
	Error::new_simple("args to `std.array_in` must be an expression and an array")
	.with_span(expr.span),
	),
	}
	}