pooyamb / basteh Goto Github PK

Improve storage and implementors documentation:

• Lib.rs documentations (postponed for 0.3)
• Description for implementors logic
• How-tos for library development (postponed for 0.3)
• Provide better examples
• Improve readme for implementors
• Documentation for scopes and implementors details

Adding atomic operations would make sense as sled and redis already support them. But it may make this crate more complex if not done right.

• Provide numeric type support*
• Provide increment, decrement and comparation methods
• Provide passing closures to backends to do atomic operations**

* Ideally it should not be hard coded in the main crates, should give implementers enough room to specialize the behavior
** May require defining a generic Item type and depend on implementers to implement the exact behavior

Sled already provides 2 public methods for encoding/decoding values outside this crate, but it would be nice to support storing metadata in a separate tree to maximize compatibility with usebase code

Given that this is a KV store, you should be able to get an iterator of all keys.

Some errors(ex. failed decoding in sled) are ignored by default, and some others can be improved to provide more details.

• Log runtime errors/warnings wherever possible when ignoring makes sense

Update actix and tokio dependencies

Tests include so many unwraps and can be improved to provide better debug messages on failures.

• Remove unwraps
• Refactor to smaller tasks and separate logic for different operation tests
• Provide better tests for sled and redis