Include of non-modular header inside framework module about pinremoteimage HOT 14 OPEN

Do you need the support for FLAnimatedImage?

from pinremoteimage.

no we don't need FLAnimatedImage support, I used "pod 'PINRemoteImage/Core'" as a workaround

from pinremoteimage.

@chriseman sounds like you resolved the issue, I'm going to close this.

from pinremoteimage.

unfortunately now the case has come and we need the support of FLAnimatedImage for another project and we still receive the same error with version '2.1.4'

from pinremoteimage.

I do need FLAnimatedImage support. Is there any solution to this?

from pinremoteimage.

@garrettmoon any solution to this? Is it possible that the compiler directive #if USE_FLANIMATED_IMAGE is causing FLAnimatedImage to not import as a module?

from pinremoteimage.

As far as I know, if you use the "pod 'PINRemoteImage/Core'", then the USE_FLANIMATED_IMAGE flag is set to false, and FLAnimatedImage will not be imported

from pinremoteimage.

Hmm... My intention is to have it imported and it worked until switching to using frameworks. I'm using cocoapods, and I'm curious if there's something being ignored because of this compiler directive. The error is

Include of non-modular header inside framework module 'PINRemoteImage.PINRemoteImageManagerResult'

Which I think implies that the header is trying to import FLAnimatedImageView as a static framework instead of a module, hence "non-modular". The obvious culprit would be the compiler directive which may be interfering in how the compiler thinks this dependency should be imported.

from pinremoteimage.

Unfortunately I had no time to investigate the problem or the reason causing the compiler error. However what leaves me puzzled is that obviously no one before had this problem using PinRemoteImage inside of a framework.

What Cocoa Pods are you currently using?

from pinremoteimage.

1.0.1

from pinremoteimage.

ok, so at least it has nothing to do with CocoaPods, as I am still on 0.39.0

from pinremoteimage.

when I import SDWebImage in my project second time,It worn that Module FLAnimatedImage not found,and when I pod install ,it warn "... ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES ... - Use the $(inherited) flag, or - Remove the build settings from the target."
At last, I find the way that remove the SD completely,specialy in the finder ,in the pods' products,and delete the project in the simulator , then import SD again.

from pinremoteimage.

I think we need to mark FLAnimatedImage.h (and perhaps others) as a public header.
In the meantime, you can set the build option CLANG_ALLOW_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES as a workaround.

from pinremoteimage.

FLAnimatedImage has been removed from master and GIF support is now built in with PINAnimatedImageView. Is it reasonable to close this now?

from pinremoteimage.