parrainc / experiment-pedro-bot Goto Github PK

Description

Currently, the only way to interact with Pedro is by saying his name at the beginning of the message. It would be great if Pedro can respond to any message that contains his name, instead of just looking for messages that starts with his name.

Actual Behavior

Pedro does not respond to any message that contains his name.
i.e.

Say something pedro

bot won't respond anything to that message.

Expected Behavior

Pedro should respond no matter if the keyword 'pedro' is at the beginning, middle or the end of the message.

Description

When Pedro is replying to an instruction and the user who instructed Pedro to respond something, doesn't have a username defined, Pedro bot should mentioned its name instead of saying @ undefined.

Actual Behavior

Pedro respond with @ undefined when no username is set for the user who talked to him.

Expected Behavior

Pedro should respond with UserFirstName if no username defined.

possible fix: Change line 117, and passed a variable with the text to respond. That variable must be set depending on the request payload (if user has username or not.

issue description

app is verifying if message is undefined or not (in this line), but doesn't validate if the .text property is set or not before even accessing it. Getting error when trying to .toLowerCase() on null value here.

payload when sticker/gif is sent:

{
   "updated_id": 123...,
   "from": ... ,
   "chat": ... ,
   "sticker": {
      "emoji": ":)",
      "file_id": "my-sticker-file-id"
   },
"animation": { ... }
}

payload when no sticker/gif is sent:

{
   "updated_id": 123...,
   "from": ... ,
   "chat": ... ,
   "text": "this is my custom text :P"
}

Actual Behavior

response with error code 500 (server error).

Expected Behavior

message should be processed properly by pedro.

possible fix: Read .text property when text is present, and/or read sticker object to avoid error 500.