callback not found on whisper close about loop-development-kit HOT 12 CLOSED

hey @rinwa, thanks for reaching out. I just want to clarify the issue - your loop creates a whisper, updates the whisper a few times, and then you close the whisper and your loop tries to update the whisper again and it's not available, right? That would be expected behavior, as there would be no way to update a whisper after it was closed. Am I understanding this correctly? If you don't mind sharing the steps to reproduce your issue, that would be helpful.

from loop-development-kit.

from loop-development-kit.

Thanks for clarifying and adding so much context. I'm curious, where or how is your showData() function called? Is it possible that it is being called after the whisper is closed?

from loop-development-kit.

With close (Dismiss) icon of the whisper I am closing the whisper. On close get the error and this.showFlag variable value remain 1 and onClose: ( )=> { } callback not getting called. if I call the showData() function after the error in log it show like this (Failed to Update Whipser — Whisper Does Not Exist ID for ID) which is fine. but I am getting the error on close the whisper.

from loop-development-kit.

Would you be able to share all of your source code with us? That may help us reproduce and identify this issue.

from loop-development-kit.

showResult.js
import { whisper } from '@oliveai/ldk';

export default class ShowResult {
constructor() {
this.showwhisper = undefined;
this.showFlag = 0;
}

async showData(compArr) {
if (this.showFlag == 0) {
console.log('if testing-------------', this.showFlag);
whisper
.create({
label: 'Search Data',
onClose: () => {
console.log('if testing-------------', this.showwhisper);
this.showFlag = 0;
},
components: compArr,
})
.then((newWhisper) => {
this.showwhisper = newWhisper;
this.showFlag = 1;
});
} else {
console.log('else testing-------------', this.showwhisper);
this.showwhisper?.update({
label: 'Search Data',
components: compArr,
});
}
}

close() {
this.showFlag = 0;
this.showwhisper.close();
}

static onClose(err) {
this.showFlag = 0;
if (err) {
console.error('There was an error closing Intro whisper', err);
}
console.log('Intro whisper closed');
}
}

Index.js
import ShowResult from './showResult';
import { WhisperComponentType } from '@oliveai/ldk/dist/whisper/types';

(async function main() {
let search = new ShowResult();
let markdown_new = {
body: 'Your First Loop page',
type: WhisperComponentType.Markdown,
};
let compArr_New = [markdown_new];
search.showData(compArr_New);

let arr = [
'If you wanted to create the Hello World ',
'When you click Create Loop, a new VSCode editor will open with your new Loop project',
'This project contains a pre-generated package.json ',
];
let i = 0;
var interval = setInterval(function () {
if (i == 2) {
clearInterval(interval);
}
let markdown = {
body: arr[i],
type: WhisperComponentType.Markdown,
};
let compArr = [markdown];
search.showData(compArr);
i += 1;
}, 1000);
})();

After all the message shown in the whisper Just close the whisper and check the log you will find the error.

from loop-development-kit.

Hello @rinwa - I was able to reproduce your issue in the latest version of Olive Helps with the code you provided. I will be entering a bug ticket in our internal system to investigate further. Thanks for your patience!

from loop-development-kit.

Hello again - I just wanted to update you on this issue. This was indeed a bug with the whisper update process, so we have identified and fixed the issue and it will be released soon. I'll let you know here when that happens. Thanks!

from loop-development-kit.

It will be highly appreciated if you could provide release date

from loop-development-kit.

It should be coming out at the end of this week! Thank you for your patience.

from loop-development-kit.

The fix for this has been released (Olive Helps v0.44.2)

from loop-development-kit.

ok thanks, I check

from loop-development-kit.