Git Product home page Git Product logo

okta-node's People

Contributors

jdavis-okta avatar jjohnson-okta avatar kevinhe-okta avatar shakataganai avatar snofox avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

okta-node's Issues

Support Pagination more intelligantly

Pagination in the current implementation is short-sighted; only to accomplish the task at hand. At some point, the NetworkAbstraction should obey some flag that calls back with the pagination links instead of following it automatically.

link.split is not a function

var bits = link.split(";");
TypeError: link.split is not a function
node_modules\okta-node\lib\NetworkAbstraction.js๐Ÿ’ฏ37

I have added below code on line 100

if (typeof link !== "function") { 
          // safe to use the function
          var bits = link.split(";");
    }

It's working fine

Use of Version Tags

Warning people in ReadMe about breaking version changes is good, but using git tags for versioning is a better practice.
Because there are no tags in this repo, people using npm can't understand whats wrong about their app when they clone their code in a different machine and reload modules, this repo will cause problem. In a project dependent to many modules, finding error will be time consuming.

Thanks for your efforts.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.