Comments (9)
This is better, but the integration is still broken. I'm not sure exactly why. I've attached another screencast so you can see what's going on.
The weird thing is that the repo's page doesn't load on the first try in Github, but just going into the browser address bar and hitting enter makes it work. 🤷
Screen Recording 2021-03-24 at 8.26.05 AM.mov.zip
from nr1-github.
@brent-yearone absolutely! I'll update the UI
from nr1-github.
Another bit of feedback from the user: I just went through the flow to set up the GitHub integration (via the "add app" functionality. The flow is extremely unintuitive. I still managed to make it through to the end, only to be show "404 - Nerdlet "[guid].github" not found
from nr1-github.
I can't provide more details on the steps to repro, because the UI doesn't let me do it again! It's now stuck with the broken integration. I can't turn it off to try re-configuring. Here's the app in question: https://one.newrelic.com/launcher/nr1-core.explorer?pane=eyJuZXJkbGV0SWQiOiJhcG0tbmVyZGxldHMub3ZlcnZpZXciLCJlbnRpdHlJZCI6Ik16RXdNRE00Tm54QlVFMThRVkJRVEVsRFFWUkpUMDU4TVRRM01UQTBPREU0TlEifQ==&sidebars[0]=eyJuZXJkbGV0SWQiOiJucjEtY29yZS5hY3Rpb25zIiwiZW50aXR5SWQiOiJNekV3TURNNE5ueEJVRTE4UVZCUVRFbERRVlJKVDA1OE1UUTNNVEEwT0RFNE5RIiwic2VsZWN0ZWROZXJkbGV0Ijp7Im5lcmRsZXRJZCI6ImFwbS1uZXJkbGV0cy5vdmVydmlldyJ9fQ==&platform[accountId]=3100386&platform[timeRange][duration]=1800000
And I'm attaching a screen cap of what happens.
Screen.Recording.2021-03-19.at.8.33.41.AM.mov
from nr1-github.
@brent-yearone Thanks for the additional details here. Our team is taking a look at this problem you reported.
from nr1-github.
Updated the app via the catalog manager: 86eb78c
from nr1-github.
Thanks @brent-yearone we'll continue to take a look at this issue.
from nr1-github.
hey @brent-yearone, can you check the permissions on the github token you're using? i was able to recreate the errors on contributors and PRs by using a token with only public access. once i tried a token with repo access it was successful. the missing readme and wonky link are still questionable but maybe we can make some progress with the token permissions first
from nr1-github.
@LizBaker that did the trick! Thank you! Some better messaging on those errors in the UI might be nice -- especially since the fix on my end is so quick & easy. :)
from nr1-github.
Related Issues (20)
- [Repolinter] Open Source Policy Issues
- Update package dependencies HOT 1
- add HelpModal component HOT 1
- add Messages component HOT 1
- [Repolinter] Open Source Policy Issues
- Error: Cannot destructure property 'path' of 'flags' as it is undefined HOT 1
- Unable to find nerd pack in New Relic hosted instance HOT 3
- Improve user expierence with setting public github URLS
- Change storage of tokens from Nerdstorage to Nerdstoragevault HOT 4
- GitLab support HOT 1
- Read me Does not render Emojis HOT 4
- Fix nerdpack vulnerability HOT 1
- Fix other nerdpack vulnerability HOT 3
- Github token security issue HOT 6
- Fix XSS vulnerability for github links
- A user can no longer set a GitHub URL universally for an org HOT 11
- "Github Repo" link appears twice in side bar in staging HOT 4
- Dashboard widget for PRs/issues
- Does not support fine-grained personal access tokens
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nr1-github.