Git Product home page Git Product logo

Comments (10)

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024 1

That would be a good use-case for pipes integration.

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024 1

@partyka95 we don't need that, see microservices & websockets. you can use pipes with them already

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024 1

ExternalContextCreator has to be agnostic, meaning, we cannot adjust it to the GraphQL purposes. As a result, pipes won't be integrated with @nestjs/graphql package. Instead, you can keep validation responsibilities in the business logic.

from graphql.

iamclaytonray avatar iamclaytonray commented on March 29, 2024

You'd just want to write some helper functions and then implement them in your resolver file

from graphql.

pawpartyka avatar pawpartyka commented on March 29, 2024

@kamilmysliwiec To use the pipes, we need a decorators like @Body(new ValidatorPipe()) in controllers, right? Do you have plans to create a decorator for resolvers like @Args()?

from graphql.

pawpartyka avatar pawpartyka commented on March 29, 2024

Could anyone give an example?

from graphql.

VinceOPS avatar VinceOPS commented on March 29, 2024

At the present time, it looks like pipes are loaded by the PipesContextCreator, which is used by the "context creator" of RPC (microservices), WS (websocket) and Routes.
But Resolver (from nestjs/graphql) uses ExternalContextCreator (from nestjs/nest), which, at the present time, only uses the GuardsContextCreator and InterceptorsContextCreator.
It looks like the Pipes are set up between the Guards and the Interceptors and should be inserted around here in ExternalContextCreator.

@kamilmysliwiec is it correct? Would it take a lot of work to me to create a PR? Or should we do something special for GraphQL Resolvers? (Like targetting body in the rootValue (which is most likely req, if everyone's following the documentation)?)

Thanks!

from graphql.

Zeldaze avatar Zeldaze commented on March 29, 2024

Any clearer examples on how to best implement validation for mutation inputs? Things like min/max lengths, advanced type fields etc. that we are used to from packages like class-validator?

from graphql.

biels avatar biels commented on March 29, 2024

from graphql.

lock avatar lock commented on March 29, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.