Feature request: Change path of build command about docker-build-push HOT 9 CLOSED

@eevers-avisi - great news! This has been merged in. Make sure you're using v3 of this action in your workflow yaml.

FYI @techpool - working directory support has been officially added in v3.

from docker-build-push.

@eevers-avisi - I've been able to get this working on a branch with a new optional directory input. Can you give the below example a try and let me know if it works for your purposes? Note that if a standard Dockerfile already exists in the working directory, you won't have to specify it.

- uses: mr-smithers-excellent/docker-build-push@add-build-dir
  with:
    image: 'mrsmithers/hello-world'
    tag: 'latest'
    registry: 'docker.io'
    dockerfile: 'working-dir/Dockerfile.dir'
    directory: 'working-dir'
    username: ${{ secrets.DOCKER_USERNAME }}
    password: ${{ secrets.DOCKER_PASSWORD }}

from docker-build-push.

@eevers-avisi - I've updated the branch to use the directory input directly in the docker build command instead of using cd. For instance, if you pass working-dir and Dockerfile.root, it will now produce a build command that looks like:

docker build -t your-image:tag -f Dockerfile.root working-dir

Can you give this another try and let me know? If it doesn't work, if you could let me know the project structure you're working with, I can try to emulate on my side. Thanks!

from docker-build-push.

@mr-smithers-excellent It's working correctly right now!

If still needed for further optimising this enhancement, this is the structure of our project. The goals is to build a Docker image using the Dockerfile.subdir (and other files) inside subdirectory. Which is succesfully working with the latest version in @add-build-dir:

|-- Dockerfile.root
|-- subdirectory
    |-- Dockerfile.subdir

from docker-build-push.

I just saw your reaction on the following PR: #8

You said that by setting the working directory you should also achieve this. I did also try to do that before creating this issue. Unfortunately this didn't work.

from docker-build-push.

Hi @eevers-avisi - thanks for the feedback. Upon further research, it looks like you can't use working-directory in conjunction with uses, only with run. So I'll need to make some changes to get this working. Would something like this fit your use case?

    - uses: mr-smithers-excellent/docker-build-push@v3
      with:
        image: 'owner/image-name'
        tag: 'latest'
        registry: 'docker.io'
        dockerfile: '../Dockerfile' # assuming Dockerfile is at root
        directory: 'dir-name' # if running the build outside project root
        username: ${{ secrets.DOCKER_USERNAME }}
        password: ${{ secrets.DOCKER_PASSWORD }}

from docker-build-push.

@mr-smithers-excellent Yes, your example would fit my use case

from docker-build-push.

I tried to use your example and fit in into our project. Unfortunately it still doesn't work for me. I did specify the directory containing the Dockerfile and other needed files with the new directory input. Also I did have to specify the Dockerfile because it took the Dockerfile in the root of our project if I didn't. It seems that the COPY steps in the Dockerfile are still trying to fetch the files from the root of our project, instead of from the specified directory. Also the logging shows that the build command still ends with a . instead of the passed directory.

from docker-build-push.

Can you give me an overview of what your project structure looks like?

from docker-build-push.