Comments (3)
Hey @lfowles If I understand the issue correctly, the rest of UFlowNode_ComponentObserver::StartObserving()
would be executed after the loop, so only binding to Flow Subystem methods?
If so, we shouldn't call ObserveActor
in every case, as we would end up with a different issue which... we got plumbed back in August.
Shouldn't we have an additional check to prevent binding to delegates?
This is my proposed fix, what do you think?
423f293
from flowgraph.
This would also work, it's just constructed oddly with different return paths depending on which component triggers finish. If any of the 1..N-1 observed actors trigger a finish it'll return from the loop of registered components. Only if the Nth actor triggers a finish will it hit the branch you added.
from flowgraph.
This would also work, it's just constructed oddly with different return paths depending on which component triggers finish. If any of the 1..N-1 observed actors trigger a finish it'll return from the loop of registered components. Only if the Nth actor triggers a finish will it hit the branch you added.
Yes, the main benefit here, was supposed to be avoiding calling ObserveActor
prior to checking a node state. But now I realize it was pointless, as we need at least one ObserveActor
check to make this node inactive. I'm taking your change in, with a proper note in the release notes. Thanks! :)
from flowgraph.
Related Issues (20)
- Refactor numbered pins support, so it would fully safe to add regular pins
- Wrong number of newly added output pin on Sequence node HOT 1
- Make LoadRootFlow & LoadSubFlow accessible to Blueprints
- Double-Clicks of Nodes open C++ class. HOT 1
- Play Level Sequence: "Pause at End" does nothing HOT 1
- RootInstances not removing flow graph when graph has finished HOT 3
- Unreal Editor Crashing due to custom node HOT 4
- Reroute node does not format correctly when going in reverse HOT 1
- Alignment feature does not work in the FlowGraph HOT 1
- Add to the "Plugin Downloader" HOT 1
- Palette does not indent headers for sub-categories
- Nodes with Context Pins, loose ALL pins on CTRL+Z / can lead to crash HOT 2
- [Question] I'm curious about how you create and release versions different versions of engine all at once? HOT 1
- Create Welcome window when opening editor with Flow Graph for the first time
- Editor bug: drag pin connection HOT 2
- Error in Copy/Paste node HOT 2
- Copy Pasting comments broken in 5.x
- The Discord Server Link in documentation no longer works HOT 2
- [Feature] Usability Improvements HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flowgraph.