converting from boost to catch test framework about ensmallen HOT 2 CLOSED

BOOST_REQUIRE_SMALL(x, 0.015) -> REQUIRE(x == Approx(0.0).margin(0.015))

I guess you could also write REQUIRE(std::abs(x) <= 0.015), but I think it makes sense to check against the plain output (x ).

The rest looks reasonable to me, as I understand the doc REQUIRE(result == Approx(1.23).epsilon(0.0015)) is the equivalent of BOOST_REQUIRE_CLOSE(x, 1.23, 0.15), worked on a couple of examples.

from ensmallen.

The REQUIRE(std::abs(x) <= 0.015) form is certainly more compact. However, std::abs() only works for signed types. Using size_t or arma::uword wouldn't work. From what I have seen in the current tests, not all of the values that are checked are floats. Probably a minor issue, but it would be easier not to worry about these special cases by simply being consistent with the use of the REQUIRE(x == Approx(0.0).margin(0.015)) form.

from ensmallen.