Comments (8)
Changing to spec issue. The new compiler supports merging of all module declarations, including ambient external module declarations. I see no reason why we should only allow merging of internal modules and specifically disallow merging of ambient external modules. In particular, declaration files sometimes extend existing internal modules and may want to do exactly that for ambient external modules.
from typescript.
From design meeting: agreed this should merge just like internal modules.
from typescript.
Leaving open so we can make the text change to the spec
from typescript.
When I run this code in typescript I get
ldixon/foo.ts(4,16): error TS2000: Duplicate identifier '"fs"'. Additional locations:
ldixon/foo.ts(1,16)
ldixon/foo.ts(4,16): error TS2191: Ambient external module declaration cannot be reopened.
Sounds like the correct behaviour is no errors. Would be great to have an npm publish of a version with this fixed :)
from typescript.
agreed this should merge just like internal modules.
DT actually needs this. Thanks guys (/cc @Bartvds @vvakame will possibly make non-instantiated modules less necessary)
from typescript.
It seems like this doesn't work if the module is exported by assignment?
declare module "m" {
function inner(s: string);
module inner { export interface Test {t: string;} }
export = inner //error here
}
declare module "m" {
// even though we're only extending already existing submodule
module inner { export interface Other { t: number; } }
}
from typescript.
@spion The name inner
is not "shared" between declarations here -- when there's an export =
, all other declarations inside that module declaration are considered to not be visible at all
from typescript.
@RyanCavanaugh I see. The original problem is express.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/express/express.d.ts
Here, express exposes a namespace Express
to let us extend Request
. Unfortunately those extensions cannot contain types imported from ambient external modules, which means they're of limited use. However, since express-the-module is also a function, the only way to declare the module is to use declaration merging then write export = module at the end, so we can't use declaration merging for ambient external modules either.
I'll open a separate issue.
from typescript.
Related Issues (20)
- A Pragmatic, Not-Really-Typed Errors Proposal HOT 7
- Make switch exhaustiveness check as a configuration of tsc. HOT 1
- Cannot extend `XMLHttpRequest` when target is `ES5` HOT 1
- Type predicate not inferred for discriminated union?
- Compilation error when reassigning destructurig array variable names HOT 1
- Operator '<' ***CAN*** be applied to types 'number | BigInt' and 'number' HOT 7
- JSDoc typedef imports are emitted with a resolved path to node_modules
- Incorrect Path Resolution for Type Imports in TypeScript Declarations HOT 2
- All primitives can be spread in objects according to MDN but TypeScript prevents it HOT 8
- Go-to-definition should only show relevant definitions when value & type have same name HOT 3
- ArrayBuffer.isView not narrowing type HOT 2
- Update import/export specifier sort on rename HOT 3
- TS can't automatically infer type from outer function in certain cases HOT 5
- Allow non-polymorphic ("private") extension of base classes HOT 1
- Design Meeting Notes, 3/26/2024
- Shorter tuple contravariant inference gets picked over longer covariant inference when both come from rests
- Type widened prematurely in `catch` HOT 2
- Inconsistency with Template Literal Types and Conditional Types HOT 1
- Uninitialized instance properties can be accessed via initializers HOT 2
- No duplicate identifier error issued if `const` declared with function type with expandos HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.