Git Product home page Git Product logo

Comments (11)

JsonFreeman avatar JsonFreeman commented on March 29, 2024

The actual behavior here matches the spec. It appears to be by design.

from typescript.

JsonFreeman avatar JsonFreeman commented on March 29, 2024

Another interesting example where we don't error, but probably should:

var v: { [s: string]: string} = {
p: 3, // Expect an error here
q: null
}

This is a result of best common type losing information, and the nontransitivity of assignability.

from typescript.

sophiajt avatar sophiajt commented on March 29, 2024

What's the action here? If we're aligned to spec, shouldn't this just be closed as by design?

from typescript.

JsonFreeman avatar JsonFreeman commented on March 29, 2024

As I recall from discussion, the spec needs to be updated to align with the current behavior. Specifically, I think section 3.8.1 needs to not pull in call/construct/index signatures for the augmented types.

And it is a breaking change.

from typescript.

sophiajt avatar sophiajt commented on March 29, 2024

I'm confused. You mention earlier that the "actual behavior here matches the spec. It appears to be by design." If so, is there a spec change?

from typescript.

JsonFreeman avatar JsonFreeman commented on March 29, 2024

Yeah my previous comments were wrong because I misunderstood what was going on. Ignore those. It needs a spec change per my recent comment.

from typescript.

sophiajt avatar sophiajt commented on March 29, 2024

Before we make this change, please confirm that the change does not impact real world code before we make the spec change.

from typescript.

JsonFreeman avatar JsonFreeman commented on March 29, 2024

Reopening this because the validation on real world code was not done yet.

from typescript.

ahejlsberg avatar ahejlsberg commented on March 29, 2024

Doesn't break any real world code we know of.

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on March 29, 2024

Is this fixed, or by design?

from typescript.

ahejlsberg avatar ahejlsberg commented on March 29, 2024

Fixed, in that it is a change from the old compiler. Spec has been updated to reflect behavior of the new compiler.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.