Comments (11)
The actual behavior here matches the spec. It appears to be by design.
from typescript.
Another interesting example where we don't error, but probably should:
var v: { [s: string]: string} = {
p: 3, // Expect an error here
q: null
}
This is a result of best common type losing information, and the nontransitivity of assignability.
from typescript.
What's the action here? If we're aligned to spec, shouldn't this just be closed as by design?
from typescript.
As I recall from discussion, the spec needs to be updated to align with the current behavior. Specifically, I think section 3.8.1 needs to not pull in call/construct/index signatures for the augmented types.
And it is a breaking change.
from typescript.
I'm confused. You mention earlier that the "actual behavior here matches the spec. It appears to be by design." If so, is there a spec change?
from typescript.
Yeah my previous comments were wrong because I misunderstood what was going on. Ignore those. It needs a spec change per my recent comment.
from typescript.
Before we make this change, please confirm that the change does not impact real world code before we make the spec change.
from typescript.
Reopening this because the validation on real world code was not done yet.
from typescript.
Doesn't break any real world code we know of.
from typescript.
Is this fixed, or by design?
from typescript.
Fixed, in that it is a change from the old compiler. Spec has been updated to reflect behavior of the new compiler.
from typescript.
Related Issues (20)
- A Pragmatic, Not-Really-Typed Errors Proposal HOT 7
- Make switch exhaustiveness check as a configuration of tsc. HOT 1
- Cannot extend `XMLHttpRequest` when target is `ES5` HOT 1
- Type predicate not inferred for discriminated union?
- Compilation error when reassigning destructurig array variable names HOT 1
- Operator '<' ***CAN*** be applied to types 'number | BigInt' and 'number' HOT 7
- JSDoc typedef imports are emitted with a resolved path to node_modules
- Incorrect Path Resolution for Type Imports in TypeScript Declarations HOT 2
- All primitives can be spread in objects according to MDN but TypeScript prevents it HOT 8
- Go-to-definition should only show relevant definitions when value & type have same name HOT 3
- ArrayBuffer.isView not narrowing type HOT 2
- Update import/export specifier sort on rename HOT 3
- TS can't automatically infer type from outer function in certain cases HOT 6
- Allow non-polymorphic ("private") extension of base classes HOT 2
- Design Meeting Notes, 3/26/2024
- Shorter tuple contravariant inference gets picked over longer covariant inference when both come from rests
- Type widened prematurely in `catch` HOT 2
- Inconsistency with Template Literal Types and Conditional Types HOT 1
- Uninitialized instance properties can be accessed via initializers HOT 2
- No duplicate identifier error issued if `const` declared with function type with expandos HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.