WH40 id is incorrectly calculated about rtl_433 HOT 3 OPEN

Yes, of course, I miswrote 00. 0I would be correct in the comment.
I do not know whether the upper nibble is used for an ID in other units. My previous unit had 4 hex digits, this new one has 5.

from rtl_433.

I suppose there is some risk, but this is pretty compelling evidence that the previous decoding is not right. It is not 100% convincing that the missing 0x1 nibble is that one, but maybe that's the only choice. FWIW, I think all decoders should output variables for undecoded bits so that they get logged and people are aware.

All in all, I'd be ok with a PR to change this. I weight correct behavior higher than compat.

from rtl_433.

Hi @Steven-Jones911: There is a little risk to break the decoding for others, their ID could change, very small since it was 0x00 .

Can you clarify one point. You proposed to update the layout with II instead of 00 and you extract only lower nibble with the & 0xf.

So layout 0I II II with you current code .... or II II II without & 0xf... ?

from rtl_433.