Git Product home page Git Product logo

Comments (3)

matzefriedrich avatar matzefriedrich commented on September 28, 2024 1

The convenience function create_from_directory expects a single directory path expression, traverses the hierarchy, and adds all files and subfolders to the archive (you can find an example in the README file).

To create a zip archive for dvd1, you´d pass its full directory path (which would be c:\media\dvd1 in that case) to the create_from_directory method. The current implementation does not allow any filtering; it will just grab everything within the specified directory and add it to the archive.

from zip-extensions-rs.

lebe-dev avatar lebe-dev commented on September 28, 2024 1

I've implemented what i wanted but too shy to make PR and not so confident in my implementation (code quality) :))

261bb71

I've posted this commit here just to explain original idea. Yes i know that 'bool' as func argument is anti-pattern, but i don't know how to make it better.

from zip-extensions-rs.

matzefriedrich avatar matzefriedrich commented on September 28, 2024 1

No worries, sir; I can see your intentions. It is true the boolean parameter could be solved better; maybe it should just go into the FileOptions structure. I will take a close look at this.

from zip-extensions-rs.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.