Comments (4)
Fixed in 2d291bc
from halo.
I second this, it would make the API much easier and cleaner to use.
Some reasons:
- You only have a few arguments anyway so using a dictionary doesn't give you any benefits
- It's much easier to catch errors with actual parameters, because a typo won't break the code. Using dictionaries, a typo could be hidden for a long time.
- It's better in editors where auto complete and intellisense will tell you what parameters a callable takes.
That means you don't need to read the documentation just to remember each of the options.
from halo.
+1, Definitely we should. Please be pythonic.
from halo.
@althonos I agree with you. @evasseure was quick with the PR #13 too. Like I said before, I would love to incorporate this. 😄 Thank you for the suggestion. Keep them coming.
from halo.
Related Issues (20)
- BUG REPORT Spinner shows up for each function that runs
- Bug: halo's output doesn't persist as expected inside Jupter Lab
- spinner overwritten in Jupyter on Windows
- Can't get Unicode characters to show on Windows using Windows Terminal HOT 1
- Suggestion: allow spinners to be indented HOT 1
- Bug: Colorama init causes all ansi codes to be stripped when not in a tty HOT 2
- Suggestion: Added PEP 484 type hints
- Suggestion: Allow text to change when using decorate pattern. HOT 1
- threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 HOT 1
- Bug: Crash when using an animation and switching to a new animated message shorter than current position
- How to integrate with logging HOT 2
- Question[Discussion]: More maintainers? HOT 2
- feature request: any appetite for supporting dynamic text? HOT 2
- Spinner does not animate during some external function call. HOT 1
- spinner not showing
- Interview partners for research about communication in GitHub projects wanted HOT 1
- Suggestion: Close widget box when clearing the spinner on jupyter notebook
- Bug: halo not showing properly in Jenkins CI HOT 2
- Suggestion: show GIF demo of the various spinners
- BUG: Halo.__init__.<locals>.clean_up() takes 0 positional arguments but 1 was given HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from halo.