1.4.1 fails building fel with gcc 6.2.1 on Fedora about sunxi-tools HOT 6 CLOSED

You're overriding CFLAGS, killing the DEFINES that would normally get passed from our Makefile, e.g. https://github.com/linux-sunxi/sunxi-tools/blob/v1.4.1/Makefile#L25-L27. The absence of -D_BSD_SOURCE then cripples portable_endian.h.

If you wish to pass additional CFLAGS, you should preferably use EXTRA_CFLAGS instead.

Regards, NiteHawk

from sunxi-tools.

I would say that we should use CFLAGS for passing additional options (instead of inventing EXTRA_CFLAGS), because it's a common practice used by all build systems. Or at least by autotools and CMake.

It is generally a good idea to follow the principle of least astonishment :)

from sunxi-tools.

How do we ensure we get our required flags in? Add whatever we need on top of existing CFLAGS - e.g. CFLAGS += -D_BSD_SOURCE -, or pass them independently in the Makefile rules?

Additionally: Who's supposed to "win" in case of conflicts, e.g. -g vs. -s, -O0 vs. -O2 etc. ?

from sunxi-tools.

Maybe introduce a new DEFAULT_CFLAGS variable in the makefile? Then append the user supplied CFLAGS variable to it. The user's CFLAGS should have the highest priority and the power to override the default options (for example, providing -O3 option to override the default -O2). Again, this is the way how the other build systems work.

from sunxi-tools.

Yes, that seems reasonable.

from sunxi-tools.

Some information about CFLAGS: https://www.gnu.org/software/automake/manual/html_node/User-Variables.html

from sunxi-tools.