Git Product home page Git Product logo

shaco's People

Contributors

alsosylv avatar felixarbeithuber avatar fffffffxxxxxxx avatar leastrio avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

shaco's Issues

Client delete takes &str, but deleting a rune page via id needs String

As the title says, something like

	let client = rest::RESTClient::new()?;
	client.delete("/lol-perks/v1/pages/id").await?;

expects the page to be delete via the page ID, which requires the use of a String such as

	let rune_page_endpoint: String = format!("/lol-perks/v1/pages/{}", id);

But this causes an error when passing it as the paramater for client.delete

Getting error reqwest::error { kind: decode, source: error("eof while parsing a value", line: 1, column: 0) }

Getting this error when trying to post to /lol-matchmaking/v1/ready-check/accept
Tried making my own rest client and from what I can gather, it seems to stem from trying to deserialize an empty response on the post function:

pub async fn post<T: Serialize>(
        &self,
        endpoint: String,
        body: T,
    ) -> Result<serde_json::Value, reqwest::Error> {
        let req: serde_json::Value = self
            .reqwest_client
            .post(format!("https://127.0.0.1:{}{}", self.port, endpoint))
            .json(&body)
            .send()
            .await?
            .json() // <- EOF error occurs here, so message gets posted but errors on response
            .await?;

        Ok(req)
    }

Design the Websocket System

This will be a tracker and place to communicate for the Websocket implementation.
I dont like the websocket system too much, and id like to redesign it. Im not sure how i plan to redesign it but ill look at other libraries.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.