Comments (7)
It should throw or console.error in development and be silent in production.
What is a case where an extension overwrites another one and it's not a bad thing?
from koa.
well i don't see the point of being that strict. people may, for whatever reason, decide to overwrite a default property, but i don't see the point of stopping them from doing that. we can also do three options: throw, warn, and silent
from koa.
Options should be avoided where possible.
"may" and "for whatever reasons" aren't real arguments, people may also want to use koa in ruby ;)
from koa.
i wouldn't consider this an option, more like crippling the framework. you're purposely crippling extendability due to your own opinions. if tj wants koa to be an unopinionated framework, then it's better to let developers do whatever they want and just warn them that they may break things. maybe tj should define koa's philosophy on the readme :)
from koa.
oh, duh. you'd want to overwrite the default error handler at this.error
, at least in koa's current form.
from koa.
this.error is just a temporary thing, I'll have something well-defined there api-wise soonish. I like the idea, I think maybe doing it with debug()
though, and making sure DEBUG usage is really clear in the guide
from koa.
debug shows properties being defined, but did you want to warn when properties are being overwritten as well?
from koa.
Related Issues (20)
- Issue with reassigning ctx.query and type preservation HOT 2
- [feat] send json type content when call ctx.throw HOT 1
- [fix] Has callback() changed return type? Now error from eslint HOT 5
- [feat] Could a listen() shortcut function be added also for http2? HOT 3
- [fix] Some things cannot be found in the database where condition search, unless the where condition search ID HOT 3
- koa 2.14.7 No generics,I want to be able to add generics HOT 1
- [feat] when will koa 3.0 be released? HOT 3
- Koa main website example code snippets disappear HOT 4
- [feat] Objects as middleware HOT 6
- [feat] Support Web (WHATWG) stream, Blob and Response HOT 2
- Consider alternatives to http-assert (including none at all) HOT 4
- [fix] Send response as buffer HOT 4
- async issue on app.listen(...) HOT 4
- [fix] I can not get query parameters about Korean HOT 3
- [feat] Spanish translation for docs
- Routing sucks, moving back to express. HOT 1
- [fix] ctx value persists to next request after mutating ctx object HOT 3
- if "\@" in url ,the redirect result doesn't match the host of the new URL() HOT 2
- [feat] Replace npm dependency "only"
- [fix] Version 2.x introduced the URL object, which is not compatible with Node versions below 10.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from koa.