Controller-runtime and custom cache about controller-runtime HOT 9 CLOSED

@ncdc thank you for the pointer and sorry for the delay.
Adding something like this seems to work:

func ClusterAwareBuilderWithOptions(options cache.Options) cache.NewCacheFunc {
	return func(config *rest.Config, opts cache.Options) (cache.Cache, error) {
		if options.Scheme == nil {
			options.Scheme = opts.Scheme
		}
		if options.Mapper == nil {
			options.Mapper = opts.Mapper
		}
		if options.Resync == nil {
			options.Resync = opts.Resync
		}
		if options.Namespace == "" {
			options.Namespace = opts.Namespace
		}
		if opts.Resync == nil {
			opts.Resync = options.Resync
		}

		return kcp.NewClusterAwareCache(config, options)
	}
}

I would think it belongs to the wrapper. What do you think?
cc @varshaprasad96

from controller-runtime.

If you're managing the NewCache function, you need to make sure it does this:

from controller-runtime.

@stevekuznetsov

from controller-runtime.

Note: "seems to work" except that there is no label conversion for APIBinding so that I cannot filter through spec.reference.workspace.exportName and spec.reference.workspace.path but it would work for Pods for instance. Obviously the fact that not many resources support the mechanism significantly diminishes its value

from controller-runtime.

Yeah, field selectors are very hard-coded and limited :|

from controller-runtime.

Could you use an index here?

from controller-runtime.

Could you use an index here?

I am not sure to follow. My understanding is that indexes help with retrieving resources from cache not avoiding them to get cached. Please let me know what I am missing. My original intent was not to cache the resources that I don't need to save some memory. As a workaround I am filtering the event and add unnecessary apibindings into the cache. As I am not expecting a huge amount of apibindings it is not a major concern for me.

An open question is: do we see value in making a cluster aware version of controller-runtime BuilderWithOptions?
As you stated for field selectors it is not granted but possibly for the other configurations? I am happy to create a PR if the answer is yes.

from controller-runtime.

Please let me know what I am missing.

Sorry, I didn't realize your intent was to make your cache size smaller in memory. The index won't help there.

do we see value in making a cluster aware version of controller-runtime BuilderWithOptions?

I swear we had a PR open to do this .. yes, I think it's a good idea ish.

from controller-runtime.

ack. I will look at that tomorrow.

from controller-runtime.