kaydenkhor / pe Goto Github PK

Include a screenshot of the login page UI.

Currently Users are expecting the address book UI once they launch the JAR file.
However, the first UI page should be the LOGIN UI.

Should include explanation of the various buttons as well.

should be "details".

What does it mean?

I can undo and redo it multiple times and it is working perfectly though.

BEFORE:

After executing this command "edit 2 t/123":

How can we edit second tag of the person without delete the first tag?

maybe can use "edit 2 t2/123"
to edit the second tag.

Date joined shouldn't be later than today's date else it should pop out as an error.

Undo/redo feature has already been implemented. It is not in the PROPOSED status.

Currently, the only unique identifier is NAME only.
There will be 2 possible scenarios:

1. Same name but different details.
   

This should be allowed because it is possible that there are people with the same name.

2. Different names but same details.

This shouldn't be allowed because every person should have a unique handphone number and email as well.

This will cause confusion and duplicated contacts.

Suggest using more fields like name + handphone number + email as the unique identifiers for each contact to solve and answer to the above 2 scenarios.

Unable to edit the second tag of a contact.

The only way to edit the second tag is to type "edit 2 t/tag1 t/edited tag 2"
retype tag 1 and edit tag 2 in the same edit command.

Did not include the date format in the feature section of the UG.

Should clearly state the different fields of the CONTACT in the CONTACT LIST.
I.e.

Name: String

Phone: Integer...

Date: date DD/MM/YYYY (EXTREMELY IMPORTANT)

.

.

.

Users only know it after typing in the wrong format.

All of the other details are similar, if you want to use the name as the unique identifier for the contact, then you need to parse it in such a way that it has a standard format of string for NAME and trim white spaces from the input.

Else, any input error by the user will cause a duplicated contact.

BEFORE:

AFTER:

It's either you state that each contact can only contain one phone number.

Or you reject the second input of p/ in a single line command

Sometimes the log text may be too long, and sometimes the UI isn't able to display it all.

Suggestion: Include horizontal scrolling function for the UI.

This is to govern the integrity of the contact list such that it doesn't have unnecessary duplicates.

For example:

The minimum requirement to add a contact: Name, Phone, Email, Address, Date Joined.

The unique identifier for each contact is : Phone & Email address.

Any duplicates of EMAIL or PHONE numbers found in the list will be reflected as "THE EMAIL ALREADY EXIST" or "THE PHONE NUMBER ALREADY EXIST".

Name cannot be the unique identifier, because there are bound to be people to have the same name, but not email or phone number.

Did not explain what is the purpose of the RESET button on the login page.

State that each contact only able to add in one PHONE NUMBER and one EMAIL ADDRESS