Support for sidekiq/redis namespaces about go-workers HOT 4 CLOSED

Ah, yep. Supporting a namespace would be great.

There are only three redis keys per queue that go-workers touches:

1. the queue list, key name generated here:

   go-workers/manager.go

   Line 87 in 481c95d

   fmt.Sprint("queue:", queue),

2. retry sorted set, which is currently a constant:

   go-workers/workers.go

   Line 13 in 481c95d

   RETRY_KEY = "goretry"

3. inprogress list used with brpoplpush:

   go-workers/fetcher.go

   Line 114 in 9e0a6c7

   return fmt.Sprint(f.manager.queue, ":", Config.processId, ":inprogress")

I could see a config option which allows a namespace to be defined, and then some mechanism which applies the namespace to the keys above.

If you want to give it a... go, then it'd be much appreciated! If not, I can take a crack at it a bit later.

Thanks!

from go-workers.

All the arguments need to be namespaced too, an alternative might be to wrap the conn and expose a strongly typed API which knows how to apply a namespace... we could just expose the functions we need.

from go-workers.

Humm, which arguments other than the keys would you need to namespace? I believe it's just the keys (which is all redis-namespace does for the operations you listed).

There's room for a more general redis namespacing library in the golang ecosystem, but in this case, with how stable the sidekiq api is, I doubt this library would benefit from that extra complexity. I could be wrong...

from go-workers.

zrangebyscore requires all arguments except the last one to be namespaced. I agree that extra complexity isn't needed.

from go-workers.