Worker sometimes taking and acknowledging jobs after Quit(), but not finishing them about go-workers HOT 4 CLOSED

Hey @tpiha,

That's true. When calling Quit(), you're telling the workers to start gracefully shutting down (rather than immediately exiting). This includes finishing up any jobs currently in process and/or any jobs fetched from redis and waiting to be processed.

Acknowledgement happens once the entire configured middleware chain finishes (including the job portion) and only if it returns true.

Your change seems to stop all middleware actions as soon as Quit() is called, which isn't a graceful shutdown.

I'm happy to help investigate the root cause here. Can you give me a failing test case or more information about your configuration and jobs you're performing which this occurs?

Thanks,
John

from go-workers.

The problem is, it just starts some new jobs, but doesn't finish them (even though it obviously acknowledges them since it doesn't retry on starting it again).

I'll try and create some test case scenario which can be easily reproduced.

from go-workers.

Awesome, thanks so much! I'd be very interested in fixing any issue that can cause what you're describing.

I'm happy to work on some test case scenario's as well, but I need some specific details about how you're using the library, the jobs you're running, etc to know where to start.

from go-workers.

Closing this since haven't heard of any other cases, and no response. If you'd like to revisit this, please open a new issue.

from go-workers.