joomla-extensions / search Goto Github PK

It was removed in https://github.com/joomla/joomla-cms/pull/34578/files from core and needs adding to language files here

Steps to reproduce the issue

Go to Updates

Expected result

No "dev" updates

Actual result

Search Extension v 4.0.1 DEV

System information (as much as possible)

j4.0.3 and updates set to stable.

Hi
Whether there was any decision regarding place where translation process for Jooomla! 4 compatible version of search will take place?

Steps to reproduce the issue

Install latest zip from https://github.com/joomla-extensions/search/releases/latest
Publish search module in sidebar

Expected result

On entering a word to search for, results page

Actual result

Error Failed opening required '/path_to_files/components/com_content/helpers/route.php' (include_path='.:/usr/local/lib/php/')

System information (as much as possible)

Joomla 4.2.9, PHP 8.1.17, Cassiopeia

Additional comments

Steps to reproduce the issue

Currently if you run composer install and then ./vendor/bin/robo build you end up with the component files overwriting what was currently there but the module isn't cleaning up the helper.php file. We need to add a script to delete that.

Expected result

Same result upgrading from 4.0.1-dev as when installing a new 4.1.0

Actual result

Not the same

System information (as much as possible)

N/A

Hi everybody,
I just want to style mod_search a little bit more Joomla! 4 like. So this sugesstions are no issues!

Suggestion No. 1: Delete without replacement the div container in line 33 of mod_search default.php
You will need some CSS more to make it look as good as mod_finder.

Suggestion No. 2: Change the class element-invisible to visually-hidden.
Here you will need less CSS, too.

Suggestion No. 3: Replace the image button with an icon button: <input type="image" alt="' . $button_text . '" class="button" src="' . $img . '" onclick="this.form.searchword.focus();"/> with <button class="btn btn-primary" type="submit"><span class="icon-search icon-white" aria-hidden="true"></span></button>

Greetings
Markus

Steps to reproduce the issue

Installing pkg_search_4.0.1-dev.zip in a new Joomla 4

Expected result

The strings are not translated because the com_search language files are missing from the Joomla 4 language package
The table xxxx_core_log_searches is not created during installation, the following error message is displayed : 500 Table 'bdps_joomla4.x4gd6_core_log_searches' doesn't exist
The parameters are not accessible because the access.xml file is not indicated in the search.xml file of the component

Additional comments

The creation of the table in the database, the addition of the access.xml file and the linked language files make the search functional

Steps to reproduce the issue

Use Search module in sidebar

Expected result

A clean search field is shown

Actual result

Above the search field, an error is shown:
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/www/users/prachta/dtc/modules/mod_search/mod_search.php on line 44

System information (as much as possible)

Joomla! 4.2.4
PHP Version | 8.1.12
Error reporting: maximum

Additional comments

Search does work

Steps to reproduce the issue

Install search 4.0.1-dev to Joomla 4.1.0

Expected result

Make a search with a common word in articles on the site. After the search, I expect to see the searh results.

Actual result

No results found.
Total: 0 results found.

System information (as much as possible)

Additional comments

Steps to reproduce the issue

Updating from PHP 8.0.30 to PHP 8.1

Expected result

no deprecations

Actual result

System information (as much as possible)

PHP 8.1
Joomla 4.3.4

Additional comments

Steps to reproduce the issue

• Please write some articles with a log and small title.
• Go to search an article and you will see a title of article with last letter truncated.
  

I thought it was a template bug and I reported the problem to Yootheme but the support verified that even with the Cassiopea template the code output is incorrect and for this reason the title is shown without the last letter.
I try to change template in Cassiopea and the problm is the same.

The problem does not happen with short titles

Expected result

Titles in search results must be integers

Actual result

The last character of the search results title with a long title is deleted

System information (as much as possible)

Joomla 4.0.5
PHP 7.4.27
db mysql 10.3.32-MariaDB-cll-lve

Additional comments

You che see the problem on this page where first result have a title without the last character.
If you open the article you will see that the last word has an extra letter.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency joomla-projects/selenium-server-standalone to v3.141.59 (main)

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update dependency joomla-projects/jorobo to ^0.8.0 (4.0-dev)

Detected dependencies