Comments (1)
Thanks for your feedback.
> Needs better MVC separation.
Considering there are two separate views and view controllers for the same
underlying model, and there is some shared logic across platforms, the current
model has held up reasonably well.
> There are two classes defined in the same class file
GTMOAuth2ViewControllerTouch and GTMOAuth2Keychain.
Proliferation of source files in shared code makes build issues even more
challenging. Colocating related classes here is intentional.
> Needs ARC compliance.
The code predates ARC, but it interoperates fine in an ARC application.
> The finishedSelector can be removed entirely as developers should use blocks
instead.
Choice of blocks or callback selectors depends on the nature of the callback.
Selectors are still superior where the callback is substantially complex and
independent of the initiating code.
> Needs support for Storyboard UIs with segue to this authentication controller.
This project does predate Storyboards. It should be updated for those, and for
modern UI generally.
Original comment by [email protected]
on 25 Mar 2014 at 12:04
- Changed state: WontFix
from gtm-oauth2.
Related Issues (20)
- ARC compatibility HOT 3
- GTMOAuth2ViewControllerTouch does not support endpoints using HTTP basic authentication
- assertion failure at GTMHTTPUploadFetcher.m:402 when using account with no YouTube channel HOT 6
- Unable to customize navigationBar/navigationItem properties if GTMOAuth2ViewController is the rootViewController
- Authentication breaks when redirectURI is of the form scheme:/path
- Invalid convertion from BOOL to (NSMutableDictionary*) HOT 1
- JSON format issue for POJO objects as @ApiMethod parameters
- Extension Grants
- GTMOAuth2ViewControllerTouch doesn't correctly handle dismissal with a pop gesture
- GTMOAuth2Authentication.refreshScope is either useless or broken HOT 1
- Application problem (Question by non-programmer, sorry) HOT 2
- iOS 7 user interface
- auth.userEmail getting wrong email address HOT 2
- iOS setCookie HOT 3
- Hi, i got an error while using vpn HOT 1
- Support text/javascript as valid content-type for JSON responses HOT 1
- Patch for /trunk/Source/GTMOAuth2Authentication.h HOT 2
- version 1.0.126 not working properly
- Patch for /trunk/Source/GTMOAuth2Authentication.h
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtm-oauth2.