Git Product home page Git Product logo

Comments (4)

InputUsername avatar InputUsername commented on September 27, 2024

Would it be feasible to take the whitelisting a little further to provide more control to the user?

Sure! Do you have anything specific in mind?

What do these unique D-Bus names look like? The current check should be able to deal with bus names like org.mpris.MediaPlayer2.player.instance123, where the player part is constant but the instance123 changes. Then you can just whitelist player and it should work.

from rescrobbled.

Tuuuukka avatar Tuuuukka commented on September 27, 2024

What do these unique D-Bus names look like? The current check should be able to deal with bus names like org.mpris.MediaPlayer2.player.instance123, where the player part is constant but the instance123 changes.

That's the thing, they're following the same chromiumish approach, so they're all like this:

$ playerctl --list-all
chromium.instance8096
chromium.instance1145951

So there's not much to work with 😄 Of course it might be possible to change these names on the app's side, but at least every Electron based player I've used are named like this. So it might be something that's not even possible to change.

That's why I'm thinking if there'd be a way to identify the player by something else by Rescrobbled. What that would be and what it would require, I don't know. If you instantly know that it's not possible or not worth the effort, then we'll let it be!

from rescrobbled.

InputUsername avatar InputUsername commented on September 27, 2024

That's the thing, they're following the same chromiumish approach, so they're all like this:

Right, yeah then I'm afraid there isn't really any way to do this from rescrobbled's side, and I'd recommend figuring out if you can change the name of the player somehow. Sorry!

from rescrobbled.

InputUsername avatar InputUsername commented on September 27, 2024

Closing this issue as there's unfortunately not much that can be done to fix this.

from rescrobbled.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.