Git Product home page Git Product logo

mmb's People

Contributors

ikemike avatar

Watchers

avatar avatar

mmb's Issues

review

Design/Code Review 3

Project: unknown.

Developer: ISAAC

Reviewer: Savannah

Category Criteria Rating/Comments
Project Overview
Does the application function as planned and designed? Are all project objectives met? no
Does the GitHub history show regular progress on the project yes
Was peer and instructor feedback/recommendations incorporated into the project? "50-50"
Other comments/notes? no
JSPs
Is templating used (for example, header.jsp, footer.jsp, etc.)? no
Is there business logic mixed in the JSPs? no
Does the site look professionl? Is it portfolio worthy? kinda - background is awesome
Is there validation of user input? yes
Other comments/notes?
Java code quality Are methods single-purpose? yes
Is the project well-structured with well-named packages for entity, controller, persistence, etc.? yes
Are classes appropriately-sized (no monster classes)? sure
Are the same lines of code repeated at all? no
Do any classes perform very similar functions that could be candidates for super/subclass relationships? yes
Are any values hard-coded that should be in a properties file? no
Are best practices for naming variables, methods and classes followed? Maybe
Are there many branches or loops that could be simplified or broken up into smaller methods? no
Do the DAOs use Hibernate? No hard-coded sql! yes
Do the DAOs use Hibernate criteria wherever possible, minimizing the use of HQL? maybe?
Is proper exception handling used? yes
Is the code docmented appropriately? partialy
Other comments/notes?
Logging Has log4J been added? yes
Is there an appropriate number of logging statements in the code for error logging and debugging? maybe
Are appropriate logging levels used? Info, debug, error, for example. yes
Are there any System.out.printlns or printstacktrace() in the code? yes
Are the logs properly written when running as a web application? no
Other comments/notes?
Unit Tests Do they exist? yes
Do the tests pass? yes
What is the current code coverage? 99.924%
Is each test truly a unit test or are they functional tests? no
Is redundant code eliminated by using set up and tear down methods, i.e., @before, @after? no
Other comments/notes?
Security Has authentication/authorization been implemented? yes
Are there some resources that only certain users can access? yes
Are there some resources that everyone can access? yes
Other comments/notes?
Web Service/API integration Which services/apis have been implemented? api for bestbuy somewhat done? Not clear?
Is the service SOAP or RESTful? rest
Are java objects created from the service response? no
Is the service used effectively in the project? no
Does the service implementation include error handling? For example, What happens if the service is not available? um?
Other comments/notes?
Independent research topic What is the independent research topic? graphing
Is the independent research topic/technique implemented in the project? no
Other comments/notes?
Deployment Has the application been successfully deployed to Openshift or another hosting service? maybe?
Is the hosted application fully functioning? no
Other comments/notes?

review

Design/Code Review 3

Project: map my brain

Developer: Issac

Reviewer: Alex

Category Criteria Rating/Comments
Project Overview
Does the application function as planned and designed? Are all project objectives met? no
Does the GitHub history show regular progress on the project yes
Was peer and instructor feedback/recommendations incorporated into the project? 50/50
Other comments/notes?
JSPs
Is templating used (for example, header.jsp, footer.jsp, etc.)? no
Is there business logic mixed in the JSPs? no
Does the site look professionl? Is it portfolio worthy? kinda
Is there validation of user input? yes
Other comments/notes?
Java code quality Are methods single-purpose? yes
Is the project well-structured with well-named packages for entity, controller, persistence, etc.? yes
Are classes appropriately-sized (no monster classes)? sure
Are the same lines of code repeated at all? no
Do any classes perform very similar functions that could be candidates for super/subclass relationships? yes daos
Are any values hard-coded that should be in a properties file? no
Are best practices for naming variables, methods and classes followed? yes
Are there many branches or loops that could be simplified or broken up into smaller methods? no
Do the DAOs use Hibernate? No hard-coded sql! yes
Do the DAOs use Hibernate criteria wherever possible, minimizing the use of HQL? yes
Is proper exception handling used? yes
Is the code docmented appropriately? somewhat
Other comments/notes?
Logging Has log4J been added? yes
Is there an appropriate number of logging statements in the code for error logging and debugging? sure
Are appropriate logging levels used? Info, debug, error, for example. yes
Are there any System.out.printlns or printstacktrace() in the code? yes
Are the logs properly written when running as a web application? no idea
Other comments/notes?
Unit Tests Do they exist? yes
Do the tests pass? yes
What is the current code coverage? 99.9%
Is each test truly a unit test or are they functional tests? maybe?
Is redundant code eliminated by using set up and tear down methods, i.e., @before, @after? no
Other comments/notes?
Security Has authentication/authorization been implemented? yes
Are there some resources that only certain users can access? yes
Are there some resources that everyone can access? yes
Other comments/notes?
Web Service/API integration Which services/apis have been implemented? bestbuy
Is the service SOAP or RESTful? rest
Are java objects created from the service response? no
Is the service used effectively in the project? inprogress
Does the service implementation include error handling? For example, What happens if the service is not available? kinda
Other comments/notes?
Independent research topic What is the independent research topic? graphing.js
Is the independent research topic/technique implemented in the project? no
Other comments/notes?
Deployment Has the application been successfully deployed to Openshift or another hosting service? no
Is the hosted application fully functioning? no
Other comments/notes?

Instructor Feedback Week 15

Isaac, I am really looking forward to seeing this in action next week! Following are few items as you finish things up:

  • Don't worry if you are not able to make the round trip connection from headset to application, you could always explore simulating that part for the demo, right? I know it's hard to let go of something like that but I want to be sure you have time to hit the mark on the Java aspects of the project.
  • Nice job with your time log and journal. Add some content to the readme.md since this will be the first thing anyone (think future employers!) browsing your repository will see - use this to sell your product and YOU!
  • Some classes missing? I'm hoping you'll have more than the User?
  • Unit testing - be sure to have one test for each method (UserDao for example)
  • Add your db design and consider including a sql dump to the repository
  • Consider adding photos of the soldering/headset and arduino work that you've done. An flow chart of the process would be helpful too.
  • Remove System.out.println and replace with logging statements (for example, in the UserDaoWithHibernateTest)
  • When running the web application where is your log file written?
  • Openshift? Web service?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.