Git Product home page Git Product logo

Comments (1)

lyzadanger avatar lyzadanger commented on September 27, 2024

Ah! The situation we have here is a "notification" (see 4.1 on https://www.jsonrpc.org/specification). I didn't realize the spec made the distinction. This is effectively one-way communication from the client-sidebar frame to the LMS frame. The proper way to sort this is to:

  • extend the sidebar's postmessage-json-rpc with a notify function or similar. Its behavior would be subset of call. It would not set an id on the request object sent via postMessage. It would then send the message to the frame via postMessage but not expect a response (i.e. not set up listeners).
  • On the LMS side, update postmessage-json-rpc#_jsonRPCResponse to not send a response to "notifications" (requests with no id property).

The LMS-side change would need to be made first such that it wouldn't throw an error if a request object does not have an id property.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.