haliris / cub3d Goto Github PK

mini_map image not cleaned up

Currently the loop checks for '1' || '0' as the first line character, but I am afraid this could be broken easily if instead the map always has spaces as the first char or spawn positions.

Currently the map_bound counts the texture lines and empty lines as well.

Need to comply to the subject requirements of fetching the relative path to the .xpm textures files while parsing the matrix in verify_map() and store them in buffers to pass to load_assets()

If we add FR ./assets/door_frame/door_frame.txt below D ./assets/kat.xpm, it won't exit successfully.
Instead, it will have double free() issue and core dump.

in the parser_utils.c line 95, there is this logic check I don't quite understand:

if (coordinates[0] == 0 && (!is_cardinal_pos(map[0][0])))
		return (MAP_ERR);

From my understanding, this logic is to check if the starting position is valid. If coordinated[0] == 0 which means the player is at the first row, it is definitely an error. Why we need to check "$$ (!is_cardinal_pos(map[0][0])" is also true?

Some of the resources in libft is not used. Need to clean the unused ones

Added mlx library in the repo but it won't pass norminette. Need to modify the rules of checker to bypass it.