Git Product home page Git Product logo

Comments (2)

hajimes avatar hajimes commented on September 28, 2024 2

After several tries, I gave up the above architecture. Because mmh3module.c also depends on murmurhash3.h, decoupling the header file from my repo completely will hinder future development.

Instead, generated files (murmurhash3.c and murmurhash3.h) will stay in my repo, rather than being temporary files in the build time. This approach follows the structure of _hacl (used by the official hashlib) in CPtyhon's repo.
https://github.com/python/cpython/tree/main/Modules/_hacl

It still fulfills the main motivation of this refactoring, i.e., clarifying the extent of the authorship of code.

from mmh3.

hajimes avatar hajimes commented on September 28, 2024

Done in version 4.0.1.

from mmh3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.