Basic process:

1. git clone [email protected]:google/node-fastify-auto-push.git
2. cd node-fastify-auto-push/samples/static-page
3. npm start -- --h2 --ap -p 3000
4. Open Google Chrome (v65) and navigate to https://localhost:3000/, bypass security warning, see "Wikipedia" load.
5. Open DevTools > Network Tab, reload page and notice that "Initiator" isn't "Push" (as one would expect it to be):
   
6. Try using nghttp2-client as I have seen suggested for testing "Push" (wherein pushed assets are represented by an asterisk next to their asset row):

nghttp -ans https://localhost:3000
[WARNING] Certificate verification failed: Hostname mismatch
Some requests were not processed. total=23, processed=8
***** Statistics *****

Request timing:
  responseEnd: the  time  when  last  byte of  response  was  received
               relative to connectEnd
 requestStart: the time  just before  first byte  of request  was sent
               relative  to connectEnd.   If  '*' is  shown, this  was
               pushed by server.
      process: responseEnd - requestStart
         code: HTTP status code
         size: number  of  bytes  received as  response  body  without
               inflation.
          URI: request URI

see http://www.w3.org/TR/resource-timing/#processing-model

sorted by 'complete'

id  responseEnd requestStart  process code size request path
  4     +3.01ms *    +1.78ms   1.23ms  200  285 /load_1.css
 10     +3.02ms *    +1.81ms   1.21ms  200   2K /images/40px-Edit-clear.svg.png
  6     +3.17ms *    +1.79ms   1.39ms  200   3K /images/50px-Question_book-new.svg.png
  8     +3.40ms *    +1.79ms   1.61ms  200   8K /images/220px-Node.js_logo.svg.png
  2     +3.66ms *    +1.77ms   1.89ms  200  49K /load_3.css
 19     +6.59ms      +4.68ms   1.91ms  200   2K /wikipedia.ico
 21     +6.91ms      +4.68ms   2.24ms  200  17K /images/220px-Ryan_Dahl.jpg
 23     +9.00ms      +6.08ms   2.92ms  200   1K /images/28px-Free_and_open-source_software_logo_(2009).svg.png

⚠️ The nghttp command seems to immediately crash our example server after displaying the above output. The crash is noted logged like this:

npm start -- --h2 --ap -p 3000

> [email protected] start /home/tyler/tmp-code/node-fastify-auto-push/samples/static-page
> node index.js "--h2" "--ap" "-p" "3000"

(node:31382) ExperimentalWarning: The http2 module is an experimental API.
Listening on port 3000
events.js:165
      throw er; // Unhandled 'error' event
      ^

Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed
    at ServerHttp2Stream.doSendFileFD (internal/http2/core.js:1990:18)
    at FSReqWrap.oncomplete (fs.js:171:5)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at process._tickCallback (internal/process/next_tick.js:178:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: `node index.js "--h2" "--ap" "-p" "3000"`
npm ERR! Exit status 1

Other details:

• tried with Node v9.11.1 and v9.11.0 (installed via nvm)
• tried with the node --expose-http2 flag
• tried in my own barebones repo here: https://github.com/tsnieman/fastify-http2/tree/fda3ad392737cb24a2d0ca6b85451412b7b1432b (this bug also trackered here)

Please let me know if there's any additional information I should provide.
I deeply appreciate any time someone might spend thinking about this.
Thank you.

Thanks for jobs.

I have an issue when I use this module to serve multi-static routes.

import fastifyAutoPush from 'fastify-auto-push'
const fastifyStatic = fastifyAutoPush.staticServe
...
server.register(fastifyStatic, {
  root: path.join(__basename, 'resources'),
  prefix: '/resources/',
  decorateReply: false
})
server.register(fastifyStatic, {
  root: path.join(__basename, 'clients'),
  prefix: '/clients/',
  decorateReply: false
})

When I implement only the resources part, it works well. But the second clients made an error

FastifyError [Error]: The decorator 'sendFile' has already been added!

Then after some seconds, this error would happen also.

Error: ERR_AVVIO_PLUGIN_TIMEOUT: plugin did not start in time:

When I use the original fastify-static, decorateReply:false was the solution. But fastify-auto-push doesn't respect it.

What is the best practice to use this module with multi routes at once?

fastify-plugin now has its own .d.ts file. Added by fastify/fastify-plugin#29.

Delete the one in this repo and replace it with the official one.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency ava to v6
• chore(deps): update dependency fastify to v4
• chore(deps): update dependency get-port to v7
• chore(deps): update dependency gts to v5
• chore(deps): update dependency js-green-licenses to v4
• chore(deps): update dependency typescript to v5
• fix(deps): update dependency fastify-plugin to v4
• 🔐 Create all rate-limited PRs at once 🔐

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• chore(deps): update dependency @types/send to ^0.17.0
• chore(deps): update dependency typescript to ~3.9.0
• fix(deps): update dependency cookie to ^0.6.0 (cookie, @types/cookie)
• chore(deps): update dependency nyc to v15
• fix(deps): update dependency argparse to v2
• chore(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency codecov to v3.7.1 [security]
• fix(deps): update dependency fastify to v2.15.1 [security]
• fix(deps): update dependency fastify-static to v4 [security]
• chore(deps): update dependency @types/node to v20
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

as titled