Git Product home page Git Product logo

Comments (4)

chrisbanes avatar chrisbanes commented on April 20, 2024

Sounds good to me. I wonder if we need to think about adding some way to provide a different contentDescription for each loaded image. i.e: the param could be (data) -> String?

WDYT @JolandaVerhoef ?

from accompanist.

JolandaVerhoef avatar JolandaVerhoef commented on April 20, 2024

I agree. If the visual element has semantic meaning, that meaning is probably changing depending on the image you're loading.

I do wonder how often we expect an asynchronously loaded image to actually have semantic meaning, and thus require a content description. We could consider defaulting this parameter to an empty lambda, so consumers only have to define it when their data actually contains a content description.

from accompanist.

chrisbanes avatar chrisbanes commented on April 20, 2024

Thinking about this a little more, maybe a normal String parameter is better.

If devs need to change it, they can use a mutableStateOf for the value.

from accompanist.

chrisbanes avatar chrisbanes commented on April 20, 2024

This was fixed in #184

from accompanist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.