Git Product home page Git Product logo

Comments (2)

chrisbanes avatar chrisbanes commented on March 29, 2024

This is an interesting one.

So the issue is that I'm calling Picasso.get(...).resize(composableSize).onlyScaleDown(), which scales the bitmap to to fill the bounds (ignoring aspect ratio). This is very different to Coil's handling, which never changes the aspect ratio (much, much better imo).

Now, we two options: centerCrop() or centerInside(), and neither are perfect.

  • centerCrop() is the right solution if you're using ContentScale.Crop (it does the same thing), but it breaks the other ContentScales.
  • centerInside() maintains aspect ratio, but scales down. So images might be scaled smaller than the composable, and then scaled back up via the ContentScale which will look bad.
  • Ideally I want a centerOutside(), which will scale the image so that both dimensions are >= requested bounds (i.e. it covers the bounds), similar to Coil's Scale.FILL

I think I'll have to go with the correct solution: centerInside().

from accompanist.

alexjlockwood avatar alexjlockwood commented on March 29, 2024

thanks for the quick fix chris!

from accompanist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.