Comments (2)
This is an interesting one.
So the issue is that I'm calling Picasso.get(...).resize(composableSize).onlyScaleDown()
, which scales the bitmap to to fill the bounds (ignoring aspect ratio). This is very different to Coil's handling, which never changes the aspect ratio (much, much better imo).
Now, we two options: centerCrop()
or centerInside()
, and neither are perfect.
centerCrop()
is the right solution if you're usingContentScale.Crop
(it does the same thing), but it breaks the otherContentScale
s.centerInside()
maintains aspect ratio, but scales down. So images might be scaled smaller than the composable, and then scaled back up via theContentScale
which will look bad.- Ideally I want a
centerOutside()
, which will scale the image so that both dimensions are>=
requested bounds (i.e. it covers the bounds), similar to Coil'sScale.FILL
I think I'll have to go with the correct solution: centerInside()
.
from accompanist.
thanks for the quick fix chris!
from accompanist.
Related Issues (20)
- [Test Harness]
- [Navigation Material] onResume/onPause lifecycle events are not received for bottomSheet destination HOT 1
- [Navigation Material] Incorrect back behavior with nested navigator HOT 2
- Stop [Permissions]
- Incorrect behaviour when bottom sheet is closed by clicking on its background HOT 3
- [Navigation Material] HOT 1
- [BottomSheetNavigator] NullPointerException (race-condition?) when using back button HOT 6
- [WebView] Doesn't save state when recycled in a LazyColumn HOT 2
- [WebView] Question about backwards writes HOT 5
- Vector animation is broken with newer libraries HOT 3
- False positive deprecation message on pagerTabIndicatorOffset variant HOT 2
- onPermissionsResult isn't triggered on POST_NOTIFICATIONS permission request (API 33). HOT 1
- [Test Harness] Deprecate with replacement of `DeviceConfigurationOverride`
- Incorrect deprecation of pagerTabIndicatorOffset
- [Permissions] Gradle update crashing permission request and the app HOT 8
- Crash when using ProgressIndicator with `accompanist-permissions` 0.34.0 HOT 1
- [Navigation Material] Crash in BottomSheetNavigator when user goes back HOT 3
- [Navigation Material] Status bar not scrimmed when bottom sheet is shown HOT 1
- [LazyColumn] scroll observation scope does not exist HOT 2
- [Feature request] LazyTable with nested scrolling support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accompanist.