Git Product home page Git Product logo

Comments (4)

bojjenclon avatar bojjenclon commented on September 27, 2024 1

Oh nice, yeah I think this is very good for the time being. Thanks for the fix!

from godot-lua-pluginscript.

gilzoide avatar gilzoide commented on September 27, 2024

Well, not everything in Lua is a table. Since we're using the FFI, some things are actual Godot Objects, including the script instance owner.

I just realized that I forgot to make script instances, e.g. self in script methods, be considered Objects when creating Variants.
So, for now, you'd have to pass self.__owner, which is very annoying:

some_array:sort_custom(self.__owner, 'some_method_name')`

At least this is easy to fix =]

Now, if you have another object with the right method, you can use it right away:

local sorter_object = GD.load('res://mysortingobject.gd_or_lua_or_cs_or...'):new()
some_array:sort_custom(sorter_object, 'some_method_name')

Another thing I was thinking that could be done is a way to wrap functions and regular tables as Godot Objects, just like there is one for coroutines. This should make this kind of method passing easier. It could even be done transparently, creating a Variant from a Lua function would create this object automatically.

If it's done, we could patch those functions that accept methods to check for function values, so that we could do like some_array:sort_custom(function(...) end) without needing to pass a method name.

from godot-lua-pluginscript.

bojjenclon avatar bojjenclon commented on September 27, 2024

I see, the self.__owner explains the issue I was having then. I had tried to use a method bound to self and it wasn't working.

I like the idea of having a way to wrap Lua functions or table as objects. I wouldn't say its "high priority" or anything since I can get it to work without that feature, but being able to dynamically create these things could be very helpful. Essentially would let us use anonymous functions/lambda type functionality for any Godot method that normally requires an object passed in.

from godot-lua-pluginscript.

gilzoide avatar gilzoide commented on September 27, 2024

Ok, so it turns out script instances were being considered as object correctly when creating Variants, but Array.sort_custom was expecting an actual godot_object * and its implementation is not based on Variants, so a new conversion needed to be done.

e82551f fixes this, so at least some_array:sort_custom(self, 'some_method_name') is now possible.

Someday we might make it accept actual Lua functions, but for now this fix is enough for being equivalent to GDScript.

from godot-lua-pluginscript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.