fibbs / nagios-check_dnsbl Goto Github PK

I have added also some other DNSBLs to the list and then one IP address I am monitoring was listed in one of them, the script reported this (IP changed for privacy):

$ check_dnsbl.sh -H 192.0.2.41
check_dnsbl.sh: FOUND_BLACKLISTS[1]=dnsbl-3.uceprotect.net: not found
192.0.2.41 is blacklisted in 1 DNSBLs
#1: zombie.dnsbl.sorbs.net

The first output line is an error because my /bin/sh is not a bash (may be the case on your system, so /bin/sh may understand bash syntax as well). It seems that /bin/sh does not support arrays, so I changed to bash, which fixed that.

Then the real error is that the IP address is listed in 'dnsbl-3.uceprotect.net' and not in the reported 'zombie.dnsbl.sorbs.net', which was the last DNSBL in my list.

Here the diff what I changed to get that working as well:

--- check_dnsbl.sh.orig	2022-12-25 19:38:16.000000000 +0100
+++ check_dnsbl.sh	2022-12-25 19:39:49.000000000 +0100
@@ -71,7 +71,7 @@
 	for BL in "$FOUND_BLACKLISTS[@]"
 	do
 		count=$(($count + 1))
-		echo "#${count}: $i"
+		echo "#${count}: ${FOUND_BLACKLISTS[$count]}"
 	done
  	exit 2
  fi