Git Product home page Git Product logo

Comments (11)

vjeux avatar vjeux commented on March 29, 2024

Can you be more precise for "it didn't work"?

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

I tried create-react-app in a subdirectory of a different project.

How did you do it?

from create-react-app.

lacker avatar lacker commented on March 29, 2024

$ npm run create-react-app ../graphql-hacks/foobar
cd ../graphql-hacks/foobar
npm start

And then it failed with a bunch of errors similar to "Module not found: Error: Cannot resolve module 'webpack-dev-server/client' in /Users/lacker/graphql-hacks/foobar".

graphql-hacks in this case already has a package.json. When I ejected, it worked. The resulting functional post-eject code is at https://github.com/lacker/graphql-hacks/tree/master/fromscratch if you are curious to see it.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Oh, this is not supported (the argument is supposed to be the project name, not a path).
Maybe we should throw if it contains a slash to keep it simple.

from create-react-app.

vjeux avatar vjeux commented on March 29, 2024

@gaearon the cli is designed to work with a path. I think the issue is the isNodeModules detection

from create-react-app.

vjeux avatar vjeux commented on March 29, 2024

I've tried it inside of jest ( https://github.com/facebook/jest ) and it throws with Cannot find module 'babel-eslint'. For some reason it reads the .babelrc file of jest instead of the one that is provided by the babel-loader. I'm trying to figure out what's going on.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Interesting. Maybe Babel still looks for .babelrc even though we're giving a config to babel-loader in a query. Perhaps it tries to merge them or something.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Okay, I got the Jest case working locally. It happens because of eslint config being autodiscovered. The only fix I found so far is to just embed the whole config into Webpack config, and pass useEslintrc: false.

Since we plan to maintain our own anyway, I’ll try to get this working.

from create-react-app.

lacker avatar lacker commented on March 29, 2024

I can reproduce the same problem if I just create it in a new directory that has no eslint. To get this I just did npm run create-react-app ~/blarg and then it could not find babel or webpack-dev-server/client. Does that work for you guys?
screen shot 2016-07-19 at 2 32 30 pm

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

@lacker Can you still reproduce this with master? It works for me:

screen shot 2016-07-20 at 00 27 43

from create-react-app.

lacker avatar lacker commented on March 29, 2024

Still doesn't work for me, but I'll open a new issue with more specific info.

from create-react-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.