Git Product home page Git Product logo

Comments (5)

spencer-tb avatar spencer-tb commented on September 27, 2024

Nice - should be changed here:

https://github.com/ethereum/execution-spec-tests/blob/main/tests/cancun/eip4844_blobs/test_excess_blob_gas.py#L518

from execution-spec-tests.

winsvega avatar winsvega commented on September 27, 2024

also the names are too general like this one:
invalid transaction referes actually to an invalid blob transaction. and within inside the transaction could be much more exceptions. I suggest using exception codes like INVALID_TR_1 that will refer to particular exception string

from execution-spec-tests.

winsvega avatar winsvega commented on September 27, 2024

also here you put an expected exception, but the returned exception is actually different

Error: insufficient_account_balance Not found in client response to postmine block tweak!
Import result of postmine block: 
'Error importing raw rlp block: max priority fee per gas higher than max fee per gas: address 0xa94f5374Fce5edBC8E2a8697C15331677e6EbF0B, maxPriorityFeePerGas: 8, maxFeePerGas: 7',
 Test Expected: 
'insufficient funds for gas * price'
 (cancun/eip4844_blobs/001-fork=Cancun--exact_balance_minus_1-tx_max_fee_per_blob_gas=1-no_calldata-tx_value=0-tx_max_priority_fee_per_gas=8, fork: Cancun, block: 1)

from execution-spec-tests.

winsvega avatar winsvega commented on September 27, 2024 
Error: Invalid params Not found in client response to postmine block tweak!
Import result of postmine block: 
'Error importing raw rlp block: blob transaction with zero blobs',
 Test Expected: 
'unknown block type'
 (cancun/eip4844_blobs/000-fork=ShanghaiToCancunAtTime15k-no_blob_tx, fork: ShanghaiToCancunAtTime15k, block: 1)

Can be that Invalid params in the produced test stands for multiple different exceptions. such as invalid block encoding and tx with 0 blobs.

from execution-spec-tests.

winsvega avatar winsvega commented on September 27, 2024

fixed now with the PR

from execution-spec-tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.