dsciitbbs / acl Goto Github PK

@PalAditya What exactly is the intention behind this line?
File paths in Windows and *Nix are a little different.

The file path points to /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.7\\attendance_past.txt.
Here first \ is taken as an escape character and the cache file with the name 3.7\attendance_past.txt is created at /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/.

This is bad for two reasons

1. Need for sudo as mentioned in #4 (comment) only because the file path points to a root location.
2. The cached file should be specific to a user, so it should be stored inside his/her home directory.

I don't think this was the intention in mind while writing the code, although it works as expected.

Currently, acl can be installed by pip install acl-iitbbs but it isn't in CD with this repo as of now. Look for the possibility to make it CD with this repo.

Right now, a query is done for every day in the range. Tweak it so that we perform a binary search on the ranges and discard a range in which student was never absent.

See: #4

Right now, all the travis script does is check if the help function in acl is working or not, so a totally broken implementation of the actual code (fetching attendance) can easily pass.

We need to implement stronger test cases via Pytest and CodeCov.

@apsknight @MadhavChoudhary should we look into something like pycodestyle/pylint to enforce proper formatting as well?

Update asciinema in README with the latest missed class feature.

The 'result' dictionary returned in 'missedClassScrapper.py'' should contain a list of values of all the subjects of which classes are missed. Currently only one subject is showing and the rest are overwritten.