doctrine / orientdb-odm Goto Github PK

As soon as it gets released

http://code.google.com/p/orient/wiki/Indexes

currently some classes implementing our interfaces define custom public methods that should stay into the interface

It belongs to the string formatter:
https://github.com/odino/Orient/blob/master/Query/Formatter.php#L427

Factory? Pimple?

Currently, every command uses a setToken(..., array(...), ...) method, we should avoid it and create a method to pass a single value for that token, not an array:
https://github.com/odino/Orient/blob/query-builder/Query/Command/Index/Create.php#L21

The repository class is responsible to expose straightforward methods to find elements in a determined collection.

It encapsulates the manager, in order to do queries and hydrate objects.

http://code.google.com/p/orient/wiki/Types

I've implemented string, boolean and date/datetime only.

passing Classes instead of objects:
https://gist.github.com/976419

test now don't have any descriptive error messages and there's a few duplicated code

http://code.google.com/p/orient/wiki/SQLDelete

Commands - and other classes - have lots of public methods (~90%).
We should verify if they are needed as public or not.

Thinks about triggering events in object important lifecycle phases.

http://pooteeweet.org/blog/0/1932#m1932

https://github.com/odino/Orient/blob/master/Query/Formatter.php#L324
https://github.com/odino/Orient/blob/master/Query/Command.php#L270

In the formatter there are multiple references to the String class.

Basically, implements the UnitOfWork pattern.

http://code.google.com/p/orient/wiki/SQLUpdate

In order to generate report files with php codebrowser it is needed to generate a bash script able to use:

• phpunit
• phploc
• phpcpd
• phpdcd
• phpmd

to generate log files to analyze with PHP_CodeBrowser.

https://github.com/odino/Orient/pull/35

Currently, the quey builder is a dead object, meaning that it is implemented following OrientDB docs, but as they get frequently outdated, to release a beta version of the QB, a series of integration tests need to be done.

In order to create the tests we need the Graph\Manager class, with some methods like createQuery() and getRaw (no hydration for now).

Now, the commands (Select, Insert, ...) are hardcoded into the query class, see, for example:
https://github.com/odino/Orient/blob/query-builder/Tests/QueryTest.php

I think we should avoid this behavior (for testability/refactoring/overridability purposes) and decide wheter we do class or object injection.

https://groups.google.com/forum/#!topic/orient-database/ThHp6EBEpP0

CC is 100%, but some classes are tested through the QueryTest, not their own test.

• Index/Create
• Index/Drop
• References\Find
• Formatter
• Property
• OClass
• Oclass\Create
• Oclass\Drop
• Property\Create
• Property\Drop
• Delete

https://gist.github.com/426304

https://github.com/odino/Orient/blob/master/Query/Formatter.php

in order to use a single format($token, array $values) method with a SWITCh statement:
https://gist.github.com/988904

In order to generate a doxygen documentation and publish it on github

Sections to document better are the binding and the query builder.

I just noticed this issue while going through the code of Orient, and easily reproduced it with the following snippet:

<?php
$query = new Orient\Query();
$sql = $query->from(array('test'))->where('text = ?', 'ME, AND YOU')->getRaw();
// SELECT FROM test WHERE text = "ME AND YOU"

If you look at the generated SQL code, you will notice that the value specified for text has been altered by removing the comma. The cause is actually pretty easy to spot and these two lines are the obvious culprit, but I'm left wondering if the current implementation of the token formatters is in fact a bit too naive.

implement public setters instead of forcing constructors to bhave in a pre-determined way

http://code.google.com/p/orient/wiki/SQLCreateLink

can be found via doxygen or the IDE

https://gist.github.com/976213

OUser -> User
OStudent -> User
OSarcazzi -> User
...

now, it's bound to the HTTP protocol, using a StdClass object containing N result.

We need to change this in order to improve protocols interoperability: an array of StdClass objects should work fine.

https://github.com/odino/Orient/blob/mapper/ODM/Mapper.php#L116