Git Product home page Git Product logo

Comments (12)

smontlouis avatar smontlouis commented on March 29, 2024

Beat me to it :).

👍

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

Sorry about that, let me check it out. I try to make sure I test everything before it's pushed but obviously not well enough. Might need to figure out some way of running tests for this.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

@SACRD @bulby97 I just pushed a hotfix to master to fix this by including history (which is a recent addition required by react-router) in vendor dependencies. I've opened up #77 to investigate better solutions to problems resulting from the vendor bundle, so hopefully a more robust solution can be found.

from react-redux-starter-kit.

SACRD avatar SACRD commented on March 29, 2024

@davezuko hotfix works fine (in dev and dev:debug)! Thank you very much!

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

Awesome, glad that fixed it :). I'll close this for now and will try to test HMR more thoroughly in future updates.

from react-redux-starter-kit.

smontlouis avatar smontlouis commented on March 29, 2024

@davezuko thank you ! Do you plan to add react-transform-catch-errors ? I made a PR

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

@bulby97 I toyed with the idea for a while and couldn't really decide, mainly because I haven't used it yet (though it does look really cool). It seems like it would be worthwhile, so I'll check it out later; I don't have any real argument against integrating it.

Also, on a somewhat unrelated note @bulby97 and @SACRD , do you find yourselves using dev or dev:debug more often? I'm curious if the :debug distinction is even necessary, or if they should be flipped (default enables debugging, with an option to disable it). I don't think it's a problem right now, but I think dev should fit whatever the primary use case is.

from react-redux-starter-kit.

smontlouis avatar smontlouis commented on March 29, 2024

In my opinion, it's kinda verbose to use dev:debug, and I use more often dev:debug. I recommand to use redux dev tools as default debugging, and use this PR reduxjs/redux-devtools#107 :)

from react-redux-starter-kit.

SACRD avatar SACRD commented on March 29, 2024

@davezuko i'm using dev:debug more often because of state re-evaluating.

from react-redux-starter-kit.

smontlouis avatar smontlouis commented on March 29, 2024

@davezuko Actually it's possible to use ctrl+h to hide redux devtools reduxjs/redux-devtools#12

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

@bulby97 yeah you can, but you also need to enable the devtools middleware for the store which people may not always want to do. I have a branch going right now to flip dev and dev:debug.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

@SACRD @bulby97 dev now enables devtools by default, but can be overriden with dev:no-debug if you want. #82

from react-redux-starter-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.