Git Product home page Git Product logo

Comments (3)

datalorax avatar datalorax commented on September 27, 2024

Just an FYI @ohmaddi this is ready to go. There's an open PR you can add edits to if you'd like (I'm okay waiting to merge since the term hasn't started) and the preview is here.

Whenever you get around to this is fine - no pressure at all. But if you think you won't be able to get to it before the term starts then I'll probably just merge it in and we can do the edits later.

from sds-r.

ohmaddi avatar ohmaddi commented on September 27, 2024

@datalorax I just completed the chapter review. It is really good and super helpful. I only made some minor text edits and one html comment regarding the repo initial files (gitignore and MIT license).

Now that I read the chapter and finally understand the branching process much better (thank you), I realized I should have created a new branch for the review itself instead of making changes directly to your branch. But as I said the changes were minor. The next review should go smoothly with no mistakes.

All the changes were pushed to the remote. You only need to look at the comment and then you can go ahead and merge.

from sds-r.

datalorax avatar datalorax commented on September 27, 2024

Thanks @ohmaddi! I'm fine with you pushing directly to this branch. I'll take a look and get it merged in later today!

from sds-r.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.