Changing Lexer and Parser to be no longer factory const. about angular_ast HOT 4 CLOSED

Just an idea. If this change has strong disadvantages, also an Expando can be used to attach data to const instances.

from angular_ast.

I'm OK with both of these changes. If we want to ever have a "mode" of the Lexer / Parser that was fail fast and const, I can always add it back in with an interface of some sort. SGTM @mk13

from angular_ast.

Thanks for the response! I'll do some experimentation to see what would be the best steps moving forward, but good to know it's okay to change this.

from angular_ast.

In general if you or @MichaelRFairhurst need something changed, feel free to propose it. My only main concern will likely be if it makes the public API much more confusing for the common case or if it will cause performance regressions for the compiler (i.e. non-interactive clients).

from angular_ast.