misplaced statement in bool ofxLua::exists(const string& name, int type) about ofxlua HOT 8 CLOSED

Do have you sample code to illustrate that this is a bug?

from ofxlua.

Yes, but it is embedded in a large project, so it is not very practical to send you this.

But for instance try ofxLua::isFuction on a function in a table. Without the suggested modification you will end up in the ofLogWarning part, when the requested name in reality is a function. If you want, I can create a small example. Only not now, but later this day.

from ofxlua.

I ask because I don't completely understand the Lua stack api 100%, so I'm curious why this is an issue as it seems to work fine. I also noticed it also seems to work fine if I change all calls within the else statement to LUA_STACK_TOP-1.

from ofxlua.

Ok, later this day I'll try to send you a little example. But it boils down to this. The lua_getfield pushes the object on the stack that you want to test if it is a object with the requested type or not. The line after that, you want to test if the previous top of the stack is a table. But you test the current top, not the previous one.

from ofxlua.

I se the issue using the read test script in luaExample and the following:

// check if testing existence within a table works
lua.pushTable("atable");
ofLogNotice() << "is atable.afunction a function?: " << lua.isFunction("afunction");
lua.popTable();

from ofxlua.

Let me now if you find any other stack issues like this as I imagine there might be another somewhere.

from ofxlua.

Thanks for the correction, I'll keep you informed if I come across other issues.

from ofxlua.

This fix is also merged into the number branch.

from ofxlua.