Git Product home page Git Product logo

Comments (2)

clarkduvall avatar clarkduvall commented on September 27, 2024

It looks like fnv hasher might not be giving very uniform hash values. Have you tried using a different hash function like MD5 or Murmur3? If I print out the hashes generated from fnv they look like this:

...
0xc2081194a0
0xc2081194f0
0xc208119540
0xc208119590
0xc2081195e0
0xc208119630
...

And if I edit your example to append a random string to each Add call, the numbers look much better:

BenchmarkHLLPPBug      50000         36573 ns/op
--- BENCH: BenchmarkHLLPPBug
    bench_test.go:87: count hll1 =  1000
    bench_test.go:88: count hll2 =  1000
    bench_test.go:93: count hll1 | hll2 = 1999
    bench_test.go:87: count hll1 =  1000
    bench_test.go:88: count hll2 =  1000
    bench_test.go:93: count hll1 | hll2 = 1998
    bench_test.go:87: count hll1 =  1000
    bench_test.go:88: count hll2 =  1000
    bench_test.go:93: count hll1 | hll2 = 1998
    bench_test.go:87: count hll1 =  1000

from hyperloglog.

tuxlinuxien avatar tuxlinuxien commented on September 27, 2024

Interesting, I am using fvn hash for other purpose and just add each of them into an HLL object. I might consider using Murmur3.

Thanks a lot.

from hyperloglog.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.