Comments (7)
With newer requests versions, we need to change res.error to res.reason. Sorry I thought I'd sorted this. Could you do a PR?
from ckanext-qa.
Just to be sure, I have requests==2.3.0, is this the right version?
from ckanext-qa.
Yep, 2.3 is fine. 2.7 also. The requirements are now requests>=1.1.0 so this should have been fixed previously, so thanks for the PR.
from ckanext-qa.
Shouldn't we do requests~=2.3
? Open bracket can lead to accidentally installing backwards-incompatible version.. (like 3.0)
from ckanext-qa.
Interesting, what does the tilde do here?
I see no reason to add an upper bound for theoretical versions. It's not as
if we're distributing releases - people tend to get the latest code from
github at the same time as they get the requirements, so if there is an
incompatible requests version then we can deal with it then.
And requests 2.0 was backwards compatible for most use cases.
On 6 November 2015 at 10:44, Krzysiek Madejski [email protected]
wrote:
Shouldn't we do requests~=2.3 ? Open bracket can lead to accidentally
installing backwards-incompatible version.. (like 3.0)—
Reply to this email directly or view it on GitHub
#21 (comment).
from ckanext-qa.
Hm, I guess tilde is for different language than Python. I've meant http://stackoverflow.com/questions/8795617/how-to-pip-install-a-package-with-min-and-max-version-range
Specyfing max version is the safest solution. If you want to be up-to-date with all the dependencies through bug reporting, that's ok. I feel one should update dependency only when there's need to.
As for releases - shouldn't ckanext-qa go along with versioning of CKAN? That was my original problem with request - I had newer CKAN with newer requests and they had to match with this extension. But if somebody is on older CKAN version who won't be able to use latest code from this repo, and won't know which commit to use.
Correct me if I'm wrong.
from ckanext-qa.
Allow me to summarize. The specific use case we're discussing is when someone is newly installing an old version of ckanext-qa. You are concerned that since then an incompatible version of requests has been released which causes them problems. I'm concerned that they may wish to use a newer version of requests due to ckan or another extension wanting it, and an upper limit on QA might suggest it is not allowed or possible. So whether we add an upper limit is a balance of probabilities of which is more helpful for more people over time. You may be right, but it's difficult to argue either way definitely.
I prefer to encourage people to use the latest ckanext-qa and we all chip in to keep it up to date. Generally there's not been any interest in the original parties who designed and wrote ckanext-qa - OKF and data.gov.uk, hence my keenness to merge the continued effort from data.gov.uk back in in PR #24 for which I'd appreciate feedback.
from ckanext-qa.
Related Issues (20)
- Move openness-element outside of organization.html-snippet or contain it in a block HOT 2
- HelperError: relative_url_for has not been defined in openness.html line 40 HOT 5
- old kombu dependency HOT 1
- Is ckanext-report optional or not? HOT 1
- Import Error: from kombu import virtual HOT 1
- 'thread._local' object has no attribute 'host' HOT 1
- How ckanext-cloudstorage and ckanext-qa could work together? HOT 1
- Is OPENNESS_SCORE_DESCRIPTION used anywhere?
- Upgrade Celery to 3.x HOT 1
- Should TaskStatus be deleted after migration to 2.0?
- Move migrate_task_status.py to CLI paster command HOT 1
- from six import viewkeys: cannot import name viewkeys HOT 1
- ImportError: cannot import name __version__ HOT 2
- ckanext-qa does not show rating stars
- qa error: update_package' object has no attribute 'get_logger' HOT 16
- qa mistakes json for txt
- No rating stars in ckan 2.8 HOT 1
- Improve/start versioning
- QA rating without downloading files HOT 1
- Incorrect rating for JPEG files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ckanext-qa.