chmarti1 / pyrodoc Goto Github PK

The html_column_table() function drops leading zeros after the decimal point.

Numpy 1.23 deprecates the function asscalar. Installing latest numpy thus breaks our code.

It's used by PMGI so we need to correct on our end. Notating so we don't forget.

New usage is given in old docs:

np.ndarray.item()

Hi @chmarti1 and @jranalli,

• The link to the handbook is broken

  pyrodoc/html/about.html

  Line 163 in 4d20404

  <b>Units:</b> Version 2.0.1 also saw the addition of a user-configurable system of units. Because unit conversion is dangerously more complicated than one might expect at first glance, the PYroMat unit conversion system is carefully documented in the <a href="handbook.pdf">PYroMat User and Developer Handbook</a>.

  and

  pyrodoc/html/about.html

  Line 172 in 4d20404

  The oldest codes used in PYroMat were variations on Newton-Rhapson iteration with maximum and minimum guesses set to guard against divergence. That approach is still implemented in the back-end <span class="code">_iter1</span> method. That works pretty well with ideal gas properties, but it fails miserably with multi-phase properties. Tests with bisection methods were highly stable, but disappointingly slow. The <span class="code">_hybrid1</span> back-end method was introduced in version 2.1.0, which implements a custom hybrid of Newton and bisection iteration. It is described in detail in the <a href="handbook.pdf">User and Developer Handbook</a>.

  It should be pdf/handbook.pdf
• These (1-5) could be actual bullets for better readability and (5) is the best reason I can imagine ;).

  pyrodoc/html/about.html

  Line 166 in 4d20404

  <b>Numerical methods:</b> Numerical iteration to invert functions is an essential part of evaluating these property models, and that is especially trick when phase changes. PYroMat has always implemented its own custom numerical codes written in pure Python. A number of programmers out there are screaming, "WHY!?" (1) It reduces the number of back-end dependencies that need to be installed and working correctly, (2) these algorithms have been studied and tuned specifically for the types of functions one is likely to get in thermodynamic property calculations, (3) design control over the algorithm makes studying and correcting numerical convergence issues much easier, (4) I've been able to very carefully engineer a balance between speed and reliable numerical convergence, and (5) because it's fun! OK, that last one is a bad reason.

• Some code blocks are outside of the paragraph-blocks

  pyrodoc/html/download.html

  Lines 74 to 78 in 4d20404

  	</p>
  	<div class="code">
  	python3 -m pip install pyromat
  	</div>
  	<p>

  some inside

  pyrodoc/html/download.html

  Lines 65 to 71 in 4d20404

  	<p>
  	On Windows systems, users simply need to right click the command propt icon and select "run as administrator" for the commands to have global effect. On a Linux or MacOS system, the Python Package Authority has historically recommended
  	<div class="code">
  	$ sudo -H python -m pip install pyromat
  	</div>
  	but this is discouraged these days. Personally, I still use this approach when installing PYroMat on most of my machines, and I have yet to regret it.
  	</p>

  Is that intentional?
• In English, do you actually say heated to a boil (

  pyrodoc/html/live/rankine.html

  Line 76 in 4d20404

  Sometimes referred to as the "steam" cycle, the Rankine cycle drove an industrial revolution and still drives most of our power plants today. In the rankine cycle, a liquid (usually water) is pumped into a boiler, where it is heated to a boil. Steam is pulled from the boiler and expanded to do work. In the old steam engines, the work was done by a piston. In modern power generation systems, it is all done by turbines. Finally, the low pressure vapor/liquid mix is cooled in a condenser. Pure liquid is drawn from the bottom of the condenser, so it will be on the saturated liquid line.

  )? Or is the asuperfluous?
• In the superheated Rankine cycle demo, work of turbines is calculated with inverted sign convention to heat transferred in the boiler, superheater and condenser. Is that intentional? See chmarti1/PYroMat@370f0b8#diff-9e1ae1a2737274e9fd787a625ea5510ed6be5a6bd9b0360186ef70fde3ff6a1aL890-L902 (I guess that is the correct place)
• The tp keyword does not work anymore

  pyrodoc/html/doc_howto.html

  Lines 153 to 154 in 4d20404

  	>>> H2O.hs(T=450.,tp=True)
  	(450.0, 9.3204107913593361, 749.29333968000344, 2774.4101890593283)

Because I am curious: Why do you leave double spaces after dots in sentences? Something to search-replace and figure out if it is a floating point or abbreviation?