Setting alertmanager's external url to a url without a port number breaks loki about loki-k8s-operator HOT 4 CLOSED

@Abuelodelanada this is an alertmanager bug but I wonder if we should catch the ChangeError and block.

from loki-k8s-operator.

@Abuelodelanada this is an alertmanager bug but I wonder if we should catch the ChangeError and block.

We are generating alertmanager config with this method:

    def _alerting_config(self) -> str:
        """Construct Loki altering configuration.

        Returns:
            a string consisting of comma-separated list of Alertmanager URLs
            to send notifications to.
        """
        alerting_config = ""
        alertmanagers = self.alertmanager_consumer.get_cluster_info()

        if not alertmanagers:
            logger.debug("No alertmanagers available")
            return alerting_config

        return ",".join([f"http://{am}" for am in alertmanagers])

We are relying in what get_cluster_info() returns.... If I understand correctly, you are saying to validate the port here?

from loki-k8s-operator.

I was thinking of maybe adding try ... except ChangeError around

  File "./src/charm.py", line 269, in _configure
    self._container.restart(self._name)

👆 that's where the traceback in the log was generated, from the pov of charm code.

from loki-k8s-operator.

Per discussion,

• Catching ChangeError and setting BlockState is debateable.
• The alertmanager issue was fixed.

Closing.

from loki-k8s-operator.