Suggestions about skada-wotlk HOT 14 CLOSED

Hi ! Sorry for my late reply and thanks a lot for your suggestions and I am glad you like what was done so far on the addon.
I received lately the same request and I was working on it (whenever I have time). The Enemy damage done is being rewritten to show almost exactly what you are both requesting. Just give me time and It shall be ready after testing it.

As for the Fails module, I will take a deeper look into it and try to enhance it even more.
Kind regards.

from skada-wotlk.

This is kind of how I see it, I will update it after testing.

from skada-wotlk.

@wojas007, keep in mind that the fails module uses the LibFails libraryto catch fails, so whatever you see on the fails list is only what the library triggered to record. the module simply watches the CombatLog and it's the library that tells it what to record. I will have a more in depth look into it. Thanks a lot for your time and suggestions.

from skada-wotlk.

As for the player Macieq, I think he received damage, because SOMEONE ELSE brought the spirit to him, and blew up about himself. Macieq just received damage, but is not guilty of anything. (and Vengeful Shade only explodes about the player who summoned it, if I'm not confusing anything)

Regarding the details of Damage Received, it would be nice to have stats like this

Enemy damage done - Select enemy - Select a Player who received damage from him <<< Now it's all there, but I want more >>> - Select an enemy attack on this player - Details on this particular attack (Total/Min/Max/Hit/Crit/Miss/Parry/Block/Evade/maybe Absorb/Resist/idk/etc)

from skada-wotlk.

It could have been the case, BUT as I mentioned above I show screenshots from Lady Deathwhisper normal encounter. On normal vengeful shades don't deal AoE damage on impact. So they can deal damage only to person who they're chasing.

from skada-wotlk.

Hey!
Thank you for your answer. SS you've sent looks like what I wanted. Can't wait for updates! Ofc there's no rush for anything.

Regards,
Wojas

from skada-wotlk.

Hey!
@bkader I downloaded latest version and I can see that you already put some updates on damage damage done by spell and enemy damage done. It looks like this for me:

1. https://i.ibb.co/N2Jc2f0/Wo-WScrn-Shot-112320-201729.jpg
2. https://i.ibb.co/tmxYRYw/Wo-WScrn-Shot-112320-205654.jpg
3. https://i.ibb.co/XYk2kzJ/Wo-WScrn-Shot-112320-205615.jpg
4. https://i.ibb.co/C0qy2m4/Wo-WScrn-Shot-112320-201731.jpg
   IT IS EXACTLY WHAT I NEEDED!!

I uploaded these specific screenshots, because for some of our Halion tries Living Inferno and Living Ember auto atacks were listed as physical. BUT only for some of the tries. For most of the tries they were listed as Fire damage (and they should be fire). Not sure whether it is server problem or addon problem.

Thanks again man!
Cheers!

from skada-wotlk.

Hi @wojas007 , glad you liked the changes that were done so far. I still have few things to test out before calling it finished skada but thanks to players like you, I am getting feedbacks, giving them temporarly solutions to test before validating them.

As for the Auto Attack, all melee attacks or auto attacks belong to the Physical schoo. You can clearly see on your screenshots that fire or shadow abilities are shown correctly. The spell school is returned by combat log events and the addon does nothing by receiving the info, recording it then displaying to the end user.

from skada-wotlk.

Um what I meant was that Living Inferno and Living Embers deal fire damage with auto atacks.
And today when we were trying to kill halion for half of our tries addon recorded adds auto atacks as fire damage and for the rest it recorded them as physical damage. But I guess it is a combat log bug then. Thanks for the answer anyways

from skada-wotlk.

Hey!
So the melee attacks are shown as I asked in the first post.
Only fail module could be more detailed, but if you won't be working on it further then you can close this ticket.

Cheers!
Wojas

from skada-wotlk.

Glad to see the absorbs and healing lua error is gone and game freezes as well. Thanks a lot for the feedback.
What kind of details you want for the fails module? Like time ... etc? If it's the case, I don't think it's necessary because fails are saved per segment, showing players who failed, what they failed and how many times and storing the exact time of the fail, in my opinion, isn't that important, unless it's a raid wiping fail.

from skada-wotlk.

Well I'm mostly interested in 2 fails I wrote about in the first post. But I cannot be more specific at the moment, because I need few raids to get some screenshots + logs. Then I'll give you more detailed description. Please, give me few days, because lately I don't have as much time to play the game - sorry.

from skada-wotlk.

Hey!
@bkader I had a chance to test fails today and I'm going to let go what I wanted from addon. I think it would be too complicated and it's not worth it.

HOWEVER, you could review Sindragosa fails, because today I didn't get a proper list of fails. No backlash at all and every other fail was not count properly. Unless my combat log bugged somehow.
Here's what I had after the fight and many people exploeded many times with backlash (I did on my druid Pniaq with 22 stacks)
https://i.ibb.co/nBQRLTK/image.png

Any chance to show list of stacks exploded at once?

1. Player 1 - 22 stacks
2. Player 2 - 16 stacks
3. Player 3 - 3 stacks
   but not as total amout but as single explosion.

If it's too much effort just close the ticket : )

Regards,
Wojas

from skada-wotlk.

Well I looked into the LibFails and there seems to be some not tested things. I really have no idea about lua code, but someone who wrote this at least added comments there:
https://i.ibb.co/jZgcnPQ/image.png

As the file is really long I don't think it's worth working on it. As I scrolled over it, there seems to be many unnecessary things there.

from skada-wotlk.