We need context.Context to interrupt request. To do this, we should create new request

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Great thank you <a class="user-mention notranslate" data-hovercard-type="user" data-ho

Do I need to add a new parameter to <div c

Add context to request. about httpreq HOT 4 CLOSED

binalyze commented on September 27, 2024

Add context to request.

from httpreq.

Comments (4)

gozeloglu commented on September 27, 2024 1

Hi @yakuter. I'd like to take this issue. Can you assign to me?

from httpreq.

yakuter commented on September 27, 2024

Great thank you @gozeloglu

from httpreq.

gozeloglu commented on September 27, 2024

Do I need to add a new parameter to

httpreq/request.go

Line 28 in ca58028

func New(address string) *Req {

function? If I do that, this change will break the tests in request_test.go. Of course, I can change the all test functions. I just want to be sure about that.

from httpreq.

yakuter commented on September 27, 2024

Yes we need to add ctx as first parameter. This is an important change, so we should change our tests too.

from httpreq.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

Comments (4)

Related Issues (6)

Recommend Projects

Recommend Topics

Recommend Org