Git Product home page Git Product logo

Comments (10)

mzabriskie avatar mzabriskie commented on March 28, 2024

Would you mind sharing a Plunker with an example of your code?

from axios.

nickdima avatar nickdima commented on March 28, 2024

This is a stripped down version of my code, in coffeescript

axios = require 'axios'
Zip = require 'adm-zip'

downloadSubitles = () ->
  axios
    url: 'http://subscene.com/subtitle/download?mac=PEuUfx42AOa6Sju0WvWBFlbLF_YeiqKwsB62_ws6DQH1khKyJy1_sj0-df29vIFw0'
  .then (response) ->
    buffer = new Buffer(response.data, 'binary')
    zip = new Zip(buffer)
    srt = zip.readAsText zip.getEntries()[0]

from axios.

mzabriskie avatar mzabriskie commented on March 28, 2024

There is a responseType property in the config, but it only works in the browser at the moment. I think we could just leverage the same property and implement it for node.js.

from axios.

nickdima avatar nickdima commented on March 28, 2024

That would be good!

from axios.

nickdima avatar nickdima commented on March 28, 2024

I've been looking a bit into this, so I think maybe we could support buffer and string for the responseType in Node.js. When it's set to buffer we would read the response stream into a buffer and when set to string just set the encoding to utf-8 and concatenate the chunks.
I could prepare a PR if you like the idea.

from axios.

mzabriskie avatar mzabriskie commented on March 28, 2024

@nickdima sorry I've totally neglected your issue. Yes, please submit a PR.

from axios.

nnarhinen avatar nnarhinen commented on March 28, 2024

Also loosely related, responseType: 'arraybuffer' does not work in the browser because responseText property is not readable in such responses. Has to be read from response instead.

image

from axios.

sorenbs avatar sorenbs commented on March 28, 2024

Looking forward to this. My use case is websites that don't properly specify encoding in headers, but do specify it in a meta tag. So I need to parse as utf-8 first, and then possibly re-parse as different content type.

from axios.

nickdima avatar nickdima commented on March 28, 2024

Sorry guys, I haven't use axios lately so I wont be able to work on that PR at this point. Maybe someone else could give it a try.

from axios.

mzabriskie avatar mzabriskie commented on March 28, 2024

I believe that this has been solved. See current http implementation https://github.com/mzabriskie/axios/blob/master/lib/adapters/http.js#L93-L96

from axios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.